diff mbox series

[ibsim,20/23] ibsim.spec.in: Improve the spec file as Fedora package guide requires

Message ID 20190102131318.5765-20-honli@redhat.com (mailing list archive)
State Not Applicable
Headers show
Series [ibsim,01/23] move sim_cmd_file into ibsim/sim_cmd.c | expand

Commit Message

Honggang LI Jan. 2, 2019, 1:13 p.m. UTC 
- Delete the 'Group' tag as it is outdated.
- Delete the 'BuildRoot' tag as it is unnecessary.
- Update the 'Source' and 'Url' tag as ibsim now hosted in github.
- The 'description' section is too long. Each line should less than
  80 characters.
- Delete the environment variables in 'build' section, as they use
  the default values.
- Simplify the 'install' section.
- The 'clean' section is unnecessary.
- The default 'defattr' tag is unnecessary.
- ibsim should own the umad2sim directory too.
- Move 'COPYING' file into the license tag.

Signed-off-by: Honggang Li <honli@redhat.com>
---
 ibsim.spec.in | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)
diff mbox series

Patch

diff --git a/ibsim.spec.in b/ibsim.spec.in
index 424b2e01ed60..d1936a300d86 100644
--- a/ibsim.spec.in
+++ b/ibsim.spec.in
@@ -7,14 +7,13 @@  Name: ibsim
 Version: @VERSION@
 Release: %rel%{?dist}
 License: GPLv2 or BSD
-Group: System Environment/Libraries
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-Source: http://www.openfabrics.org/downloads/management/@TARBALL@
-Url: http://openfabrics.org/
+Source: https://github.com/linux-rdma/ibsim/archive/@TARBALL@
+Url: https://github.com/linux-rdma/ibsim
 BuildRequires: libibmad-devel, libibumad-devel, gcc
 
 %description
-ibsim provides simulation of infiniband fabric for using with OFA OpenSM, diagnostic and management tools.
+ibsim provides simulation of infiniband fabric for using with
+OFA OpenSM, diagnostic and management tools.
 
 %prep
 %setup -q
@@ -22,20 +21,15 @@  ibsim provides simulation of infiniband fabric for using with OFA OpenSM, diagno
 %build
 export CFLAGS="${CFLAGS:-${RPM_OPT_FLAGS}}"
 export LDFLAGS="${LDFLAGS:-${RPM_OPT_FLAGS}}"
-make prefix=%_prefix libpath=%_libdir binpath=%_bindir %{?_smp_mflags}
+make %{?_smp_mflags}
 
 %install
-export CFLAGS="${CFLAGS:-${RPM_OPT_FLAGS}}"
-export LDFLAGS="${LDFLAGS:-${RPM_OPT_FLAGS}}"
 make DESTDIR=${RPM_BUILD_ROOT} prefix=%_prefix libpath=%_libdir binpath=%_bindir install
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
 %files
-%defattr(-,root,root)
-%{_libdir}/umad2sim/libumad2sim*.so*
+%{_libdir}/umad2sim/
 %{_bindir}/ibsim
-%doc README COPYING TODO net-examples scripts
+%doc README TODO net-examples scripts
+%license COPYING
 
 %changelog