diff mbox series

[for-rc] IB/ipoib: Make ipoib_intercept_dev_id_attr() static

Message ID 20190129115548.23945-1-kamalheib1@gmail.com (mailing list archive)
State Mainlined
Commit ed0bc2658e1b7c083fc7f49cc6b56ea66f5ed350
Delegated to: Jason Gunthorpe
Headers show
Series [for-rc] IB/ipoib: Make ipoib_intercept_dev_id_attr() static | expand

Commit Message

Kamal Heib Jan. 29, 2019, 11:55 a.m. UTC
The function ipoib_intercept_dev_id_attr() is only used in ipoib_main.c

Fixes: f6350da41dc7 ("IB/ipoib: Log sysfs 'dev_id' accesses from userspace")
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
---
 drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jason Gunthorpe Jan. 30, 2019, 4:51 a.m. UTC | #1
On Tue, Jan 29, 2019 at 01:55:48PM +0200, Kamal Heib wrote:
> The function ipoib_intercept_dev_id_attr() is only used in ipoib_main.c
> 
> Fixes: f6350da41dc7 ("IB/ipoib: Log sysfs 'dev_id' accesses from userspace")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
>  drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This doesn't really seem like -rc material, applied to for-next

Thanks,
Jason
diff mbox series

Patch

diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
index d932f99201d1..cb25b0df3fd1 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
@@ -2411,7 +2411,7 @@  static ssize_t dev_id_show(struct device *dev,
 }
 static DEVICE_ATTR_RO(dev_id);
 
-int ipoib_intercept_dev_id_attr(struct net_device *dev)
+static int ipoib_intercept_dev_id_attr(struct net_device *dev)
 {
 	device_remove_file(&dev->dev, &dev_attr_dev_id);
 	return device_create_file(&dev->dev, &dev_attr_dev_id);