diff mbox series

[rdma-core,5/5] build: Enable more warnings

Message ID 20190514233028.3905-6-jgg@ziepe.ca (mailing list archive)
State Not Applicable
Headers show
Series Build system updates | expand

Commit Message

Jason Gunthorpe May 14, 2019, 11:30 p.m. UTC 
From: Jason Gunthorpe <jgg@mellanox.com>

The format-nonliteral option makes sure that the input to a formatting
function is actually a format string and not something else.

date-time helps ensure reproducible builds

redundant-decls, nested-externs are just general cleanlyness other
projects tend to turn on.

Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
---
 CMakeLists.txt | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Leon Romanovsky May 15, 2019, 5:35 a.m. UTC | #1 
On Tue, May 14, 2019 at 08:30:28PM -0300, Jason Gunthorpe wrote:
> From: Jason Gunthorpe <jgg@mellanox.com>
>
> The format-nonliteral option makes sure that the input to a formatting
> function is actually a format string and not something else.
>
> date-time helps ensure reproducible builds
>
> redundant-decls, nested-externs are just general cleanlyness other
> projects tend to turn on.
>
> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
> ---
>  CMakeLists.txt | 4 ++++
>  1 file changed, 4 insertions(+)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
diff mbox series

Patch

diff --git a/CMakeLists.txt b/CMakeLists.txt
index beb8f4ec123876..31100e267f2150 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -185,6 +185,10 @@  RDMA_AddOptCFlag(CMAKE_C_FLAGS HAVE_C_WMISSING_DECLARATIONS "-Wmissing-declarati
 RDMA_AddOptCFlag(CMAKE_C_FLAGS HAVE_C_WWRITE_STRINGS "-Wwrite-strings")
 RDMA_AddOptCFlag(CMAKE_C_FLAGS HAVE_C_WFORMAT_2 "-Wformat=2")
 RDMA_AddOptCFlag(CMAKE_C_FLAGS HAVE_C_WCAST_FUNCTION "-Wcast-function-type")
+RDMA_AddOptCFlag(CMAKE_C_FLAGS HAVE_C_WFORMAT_NONLITERAL "-Wformat-nonliteral")
+RDMA_AddOptCFlag(CMAKE_C_FLAGS HAVE_C_WREDUNDANT_DECLS "-Wredundant-decls")
+RDMA_AddOptCFlag(CMAKE_C_FLAGS HAVE_C_WDATE_TIME "-Wdate-time")
+RDMA_AddOptCFlag(CMAKE_C_FLAGS HAVE_C_WNESTED_EXTERNS "-Wnested-externs")
 
 # At some point after 4.4 gcc fixed shadow to ignore function vs variable
 # conflicts