| Message ID | 20190610194911.12427-1-jgg@ziepe.ca (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | rdma: Remove nes | expand |
On Mon, Jun 10, 2019 at 04:49:11PM -0300, Jason Gunthorpe wrote: > From: Jason Gunthorpe <jgg@mellanox.com> > > This driver was first merged over 10 years ago and has not seen major > activity by the authors in the last 7 years. However, in that time it has > been patched 150 times to adapt it to changing kernel APIs. > > Further, the hardware has several issues, like not supporting 64 bit DMA, > that make it rather uninteresting for use with modern systems and RDMA. > > Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> > --- > .../ABI/stable/sysfs-class-infiniband | 17 - > MAINTAINERS | 8 - > drivers/infiniband/Kconfig | 1 - > drivers/infiniband/hw/Makefile | 1 - > drivers/infiniband/hw/nes/Kconfig | 15 - > drivers/infiniband/hw/nes/Makefile | 3 - > drivers/infiniband/hw/nes/nes.c | 1205 ----- > drivers/infiniband/hw/nes/nes.h | 574 --- > drivers/infiniband/hw/nes/nes_cm.c | 3992 ----------------- > drivers/infiniband/hw/nes/nes_cm.h | 470 -- > drivers/infiniband/hw/nes/nes_context.h | 193 - > drivers/infiniband/hw/nes/nes_hw.c | 3887 ---------------- > drivers/infiniband/hw/nes/nes_hw.h | 1380 ------ > drivers/infiniband/hw/nes/nes_mgt.c | 1155 ----- > drivers/infiniband/hw/nes/nes_mgt.h | 97 - > drivers/infiniband/hw/nes/nes_nic.c | 1870 -------- > drivers/infiniband/hw/nes/nes_utils.c | 915 ---- > drivers/infiniband/hw/nes/nes_verbs.c | 3754 ---------------- > drivers/infiniband/hw/nes/nes_verbs.h | 198 - > include/uapi/rdma/nes-abi.h | 115 - > 20 files changed, 19850 deletions(-) > delete mode 100644 drivers/infiniband/hw/nes/Kconfig > delete mode 100644 drivers/infiniband/hw/nes/Makefile > delete mode 100644 drivers/infiniband/hw/nes/nes.c > delete mode 100644 drivers/infiniband/hw/nes/nes.h > delete mode 100644 drivers/infiniband/hw/nes/nes_cm.c > delete mode 100644 drivers/infiniband/hw/nes/nes_cm.h > delete mode 100644 drivers/infiniband/hw/nes/nes_context.h > delete mode 100644 drivers/infiniband/hw/nes/nes_hw.c > delete mode 100644 drivers/infiniband/hw/nes/nes_hw.h > delete mode 100644 drivers/infiniband/hw/nes/nes_mgt.c > delete mode 100644 drivers/infiniband/hw/nes/nes_mgt.h > delete mode 100644 drivers/infiniband/hw/nes/nes_nic.c > delete mode 100644 drivers/infiniband/hw/nes/nes_utils.c > delete mode 100644 drivers/infiniband/hw/nes/nes_verbs.c > delete mode 100644 drivers/infiniband/hw/nes/nes_verbs.h > delete mode 100644 include/uapi/rdma/nes-abi.h > > As discussed. > It wasn't hard to review. Thanks Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> Subject: [PATCH] rdma: Remove nes > > From: Jason Gunthorpe <jgg@mellanox.com> > > This driver was first merged over 10 years ago and has not seen major activity by > the authors in the last 7 years. However, in that time it has been patched 150 times > to adapt it to changing kernel APIs. > > Further, the hardware has several issues, like not supporting 64 bit DMA, that make > it rather uninteresting for use with modern systems and RDMA. > > Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> > --- > .../ABI/stable/sysfs-class-infiniband | 17 - > MAINTAINERS | 8 - > drivers/infiniband/Kconfig | 1 - > drivers/infiniband/hw/Makefile | 1 - > drivers/infiniband/hw/nes/Kconfig | 15 - > drivers/infiniband/hw/nes/Makefile | 3 - > drivers/infiniband/hw/nes/nes.c | 1205 ----- > drivers/infiniband/hw/nes/nes.h | 574 --- > drivers/infiniband/hw/nes/nes_cm.c | 3992 ----------------- > drivers/infiniband/hw/nes/nes_cm.h | 470 -- > drivers/infiniband/hw/nes/nes_context.h | 193 - > drivers/infiniband/hw/nes/nes_hw.c | 3887 ---------------- > drivers/infiniband/hw/nes/nes_hw.h | 1380 ------ > drivers/infiniband/hw/nes/nes_mgt.c | 1155 ----- > drivers/infiniband/hw/nes/nes_mgt.h | 97 - > drivers/infiniband/hw/nes/nes_nic.c | 1870 -------- > drivers/infiniband/hw/nes/nes_utils.c | 915 ---- > drivers/infiniband/hw/nes/nes_verbs.c | 3754 ---------------- > drivers/infiniband/hw/nes/nes_verbs.h | 198 - > include/uapi/rdma/nes-abi.h | 115 - > 20 files changed, 19850 deletions(-) > delete mode 100644 drivers/infiniband/hw/nes/Kconfig delete mode 100644 > drivers/infiniband/hw/nes/Makefile > delete mode 100644 drivers/infiniband/hw/nes/nes.c delete mode 100644 > drivers/infiniband/hw/nes/nes.h delete mode 100644 > drivers/infiniband/hw/nes/nes_cm.c > delete mode 100644 drivers/infiniband/hw/nes/nes_cm.h > delete mode 100644 drivers/infiniband/hw/nes/nes_context.h > delete mode 100644 drivers/infiniband/hw/nes/nes_hw.c > delete mode 100644 drivers/infiniband/hw/nes/nes_hw.h > delete mode 100644 drivers/infiniband/hw/nes/nes_mgt.c > delete mode 100644 drivers/infiniband/hw/nes/nes_mgt.h > delete mode 100644 drivers/infiniband/hw/nes/nes_nic.c > delete mode 100644 drivers/infiniband/hw/nes/nes_utils.c > delete mode 100644 drivers/infiniband/hw/nes/nes_verbs.c > delete mode 100644 drivers/infiniband/hw/nes/nes_verbs.h > delete mode 100644 include/uapi/rdma/nes-abi.h > Thank you! Reviewed-by: Shiraz Saleem <shiraz.saleem@intel.com>
On Wed, Jun 12, 2019 at 06:48:53PM +0000, Saleem, Shiraz wrote: > > Subject: [PATCH] rdma: Remove nes > > > > From: Jason Gunthorpe <jgg@mellanox.com> > > > > This driver was first merged over 10 years ago and has not seen major activity by > > the authors in the last 7 years. However, in that time it has been patched 150 times > > to adapt it to changing kernel APIs. > > > > Further, the hardware has several issues, like not supporting 64 bit DMA, that make > > it rather uninteresting for use with modern systems and RDMA. > > > > Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> > > --- > > .../ABI/stable/sysfs-class-infiniband | 17 - > > MAINTAINERS | 8 - > > drivers/infiniband/Kconfig | 1 - > > drivers/infiniband/hw/Makefile | 1 - > > drivers/infiniband/hw/nes/Kconfig | 15 - > > drivers/infiniband/hw/nes/Makefile | 3 - > > drivers/infiniband/hw/nes/nes.c | 1205 ----- > > drivers/infiniband/hw/nes/nes.h | 574 --- > > drivers/infiniband/hw/nes/nes_cm.c | 3992 ----------------- > > drivers/infiniband/hw/nes/nes_cm.h | 470 -- > > drivers/infiniband/hw/nes/nes_context.h | 193 - > > drivers/infiniband/hw/nes/nes_hw.c | 3887 ---------------- > > drivers/infiniband/hw/nes/nes_hw.h | 1380 ------ > > drivers/infiniband/hw/nes/nes_mgt.c | 1155 ----- > > drivers/infiniband/hw/nes/nes_mgt.h | 97 - > > drivers/infiniband/hw/nes/nes_nic.c | 1870 -------- > > drivers/infiniband/hw/nes/nes_utils.c | 915 ---- > > drivers/infiniband/hw/nes/nes_verbs.c | 3754 ---------------- > > drivers/infiniband/hw/nes/nes_verbs.h | 198 - > > include/uapi/rdma/nes-abi.h | 115 - > > 20 files changed, 19850 deletions(-) > > delete mode 100644 drivers/infiniband/hw/nes/Kconfig delete mode 100644 > > drivers/infiniband/hw/nes/Makefile > > delete mode 100644 drivers/infiniband/hw/nes/nes.c delete mode 100644 > > drivers/infiniband/hw/nes/nes.h delete mode 100644 > > drivers/infiniband/hw/nes/nes_cm.c > > delete mode 100644 drivers/infiniband/hw/nes/nes_cm.h > > delete mode 100644 drivers/infiniband/hw/nes/nes_context.h > > delete mode 100644 drivers/infiniband/hw/nes/nes_hw.c > > delete mode 100644 drivers/infiniband/hw/nes/nes_hw.h > > delete mode 100644 drivers/infiniband/hw/nes/nes_mgt.c > > delete mode 100644 drivers/infiniband/hw/nes/nes_mgt.h > > delete mode 100644 drivers/infiniband/hw/nes/nes_nic.c > > delete mode 100644 drivers/infiniband/hw/nes/nes_utils.c > > delete mode 100644 drivers/infiniband/hw/nes/nes_verbs.c > > delete mode 100644 drivers/infiniband/hw/nes/nes_verbs.h > > delete mode 100644 include/uapi/rdma/nes-abi.h > > > > Thank you! > > Reviewed-by: Shiraz Saleem <shiraz.saleem@intel.com> Extra thing, can you please add a comment in include/uapi/rdma/rdma_user_ioctl_cmds.h near RDMA_DRIVER_NES that this driver is removed. Thanks
On Wed, 2019-06-12 at 18:48 +0000, Saleem, Shiraz wrote: > > Subject: [PATCH] rdma: Remove nes > > > > From: Jason Gunthorpe <jgg@mellanox.com> > > > > This driver was first merged over 10 years ago and has not seen > > major activity by > > the authors in the last 7 years. However, in that time it has been > > patched 150 times > > to adapt it to changing kernel APIs. > > > > Further, the hardware has several issues, like not supporting 64 > > bit DMA, that make > > it rather uninteresting for use with modern systems and RDMA. > > > > Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> > > --- > > .../ABI/stable/sysfs-class-infiniband | 17 - > > MAINTAINERS | 8 - > > drivers/infiniband/Kconfig | 1 - > > drivers/infiniband/hw/Makefile | 1 - > > drivers/infiniband/hw/nes/Kconfig | 15 - > > drivers/infiniband/hw/nes/Makefile | 3 - > > drivers/infiniband/hw/nes/nes.c | 1205 ----- > > drivers/infiniband/hw/nes/nes.h | 574 --- > > drivers/infiniband/hw/nes/nes_cm.c | 3992 ----------- > > ------ > > drivers/infiniband/hw/nes/nes_cm.h | 470 -- > > drivers/infiniband/hw/nes/nes_context.h | 193 - > > drivers/infiniband/hw/nes/nes_hw.c | 3887 ----------- > > ----- > > drivers/infiniband/hw/nes/nes_hw.h | 1380 ------ > > drivers/infiniband/hw/nes/nes_mgt.c | 1155 ----- > > drivers/infiniband/hw/nes/nes_mgt.h | 97 - > > drivers/infiniband/hw/nes/nes_nic.c | 1870 -------- > > drivers/infiniband/hw/nes/nes_utils.c | 915 ---- > > drivers/infiniband/hw/nes/nes_verbs.c | 3754 ----------- > > ----- > > drivers/infiniband/hw/nes/nes_verbs.h | 198 - > > include/uapi/rdma/nes-abi.h | 115 - > > 20 files changed, 19850 deletions(-) > > delete mode 100644 drivers/infiniband/hw/nes/Kconfig delete mode > > 100644 > > drivers/infiniband/hw/nes/Makefile > > delete mode 100644 drivers/infiniband/hw/nes/nes.c delete mode > > 100644 > > drivers/infiniband/hw/nes/nes.h delete mode 100644 > > drivers/infiniband/hw/nes/nes_cm.c > > delete mode 100644 drivers/infiniband/hw/nes/nes_cm.h > > delete mode 100644 drivers/infiniband/hw/nes/nes_context.h > > delete mode 100644 drivers/infiniband/hw/nes/nes_hw.c > > delete mode 100644 drivers/infiniband/hw/nes/nes_hw.h > > delete mode 100644 drivers/infiniband/hw/nes/nes_mgt.c > > delete mode 100644 drivers/infiniband/hw/nes/nes_mgt.h > > delete mode 100644 drivers/infiniband/hw/nes/nes_nic.c > > delete mode 100644 drivers/infiniband/hw/nes/nes_utils.c > > delete mode 100644 drivers/infiniband/hw/nes/nes_verbs.c > > delete mode 100644 drivers/infiniband/hw/nes/nes_verbs.h > > delete mode 100644 include/uapi/rdma/nes-abi.h > > > > Thank you! > > Reviewed-by: Shiraz Saleem <shiraz.saleem@intel.com> Straight forward enough. Applied to for-next, thanks.
diff --git a/Documentation/ABI/stable/sysfs-class-infiniband b/Documentation/ABI/stable/sysfs-class-infiniband index 17211ceb9bf438..aed21b8916a25a 100644 --- a/Documentation/ABI/stable/sysfs-class-infiniband +++ b/Documentation/ABI/stable/sysfs-class-infiniband @@ -423,23 +423,6 @@ Description: (e.g. driver restart on the VM which owns the VF). -sysfs interface for NetEffect RNIC Low-Level iWARP driver (nes) ---------------------------------------------------------------- - -What: /sys/class/infiniband/nesX/hw_rev -What: /sys/class/infiniband/nesX/hca_type -What: /sys/class/infiniband/nesX/board_id -Date: Feb, 2008 -KernelVersion: v2.6.25 -Contact: linux-rdma@vger.kernel.org -Description: - hw_rev: (RO) Hardware revision number - - hca_type: (RO) Host Channel Adapter type (NEX020) - - board_id: (RO) Manufacturing board id - - sysfs interface for Chelsio T4/T5 RDMA driver (cxgb4) ----------------------------------------------------- diff --git a/MAINTAINERS b/MAINTAINERS index 5cfbea4ce57503..9ac03f3e3bd562 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10830,14 +10830,6 @@ F: driver/net/net_failover.c F: include/net/net_failover.h F: Documentation/networking/net_failover.rst -NETEFFECT IWARP RNIC DRIVER (IW_NES) -M: Faisal Latif <faisal.latif@intel.com> -L: linux-rdma@vger.kernel.org -W: http://www.intel.com/Products/Server/Adapters/Server-Cluster/Server-Cluster-overview.htm -S: Supported -F: drivers/infiniband/hw/nes/ -F: include/uapi/rdma/nes-abi.h - NETEM NETWORK EMULATOR M: Stephen Hemminger <stephen@networkplumber.org> L: netem@lists.linux-foundation.org (moderated for non-subscribers) diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig index cbaafa4e030269..0fe6f76e8fdccf 100644 --- a/drivers/infiniband/Kconfig +++ b/drivers/infiniband/Kconfig @@ -86,7 +86,6 @@ source "drivers/infiniband/hw/efa/Kconfig" source "drivers/infiniband/hw/i40iw/Kconfig" source "drivers/infiniband/hw/mlx4/Kconfig" source "drivers/infiniband/hw/mlx5/Kconfig" -source "drivers/infiniband/hw/nes/Kconfig" source "drivers/infiniband/hw/ocrdma/Kconfig" source "drivers/infiniband/hw/vmw_pvrdma/Kconfig" source "drivers/infiniband/hw/usnic/Kconfig" diff --git a/drivers/infiniband/hw/Makefile b/drivers/infiniband/hw/Makefile index 77094be1b2627d..433fca59febdff 100644 --- a/drivers/infiniband/hw/Makefile +++ b/drivers/infiniband/hw/Makefile @@ -7,7 +7,6 @@ obj-$(CONFIG_INFINIBAND_EFA) += efa/ obj-$(CONFIG_INFINIBAND_I40IW) += i40iw/ obj-$(CONFIG_MLX4_INFINIBAND) += mlx4/ obj-$(CONFIG_MLX5_INFINIBAND) += mlx5/ -obj-$(CONFIG_INFINIBAND_NES) += nes/ obj-$(CONFIG_INFINIBAND_OCRDMA) += ocrdma/ obj-$(CONFIG_INFINIBAND_VMWARE_PVRDMA) += vmw_pvrdma/ obj-$(CONFIG_INFINIBAND_USNIC) += usnic/