| Message ID | 20191018094115.13167-5-kamalheib1@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | RDMA: modify_port improvements | expand |
> From: linux-rdma-owner@vger.kernel.org <linux-rdma- > owner@vger.kernel.org> On Behalf Of Kamal Heib > > There is no need to return always zero for function which is not supported. > > Fixes: ac1b36e55a51 ("qedr: Add support for user context verbs") > Signed-off-by: Kamal Heib <kamalheib1@gmail.com> > --- > drivers/infiniband/hw/qedr/main.c | 1 - > drivers/infiniband/hw/qedr/verbs.c | 6 ------ > drivers/infiniband/hw/qedr/verbs.h | 2 -- > 3 files changed, 9 deletions(-) > > diff --git a/drivers/infiniband/hw/qedr/main.c > b/drivers/infiniband/hw/qedr/main.c > index 5136b835e1ba..e5f36adb0120 100644 > --- a/drivers/infiniband/hw/qedr/main.c > +++ b/drivers/infiniband/hw/qedr/main.c > @@ -212,7 +212,6 @@ static const struct ib_device_ops qedr_dev_ops = { > .get_link_layer = qedr_link_layer, > .map_mr_sg = qedr_map_mr_sg, > .mmap = qedr_mmap, > - .modify_port = qedr_modify_port, > .modify_qp = qedr_modify_qp, > .modify_srq = qedr_modify_srq, > .poll_cq = qedr_poll_cq, > diff --git a/drivers/infiniband/hw/qedr/verbs.c > b/drivers/infiniband/hw/qedr/verbs.c > index 6f3ce86019b7..fee02ac47f32 100644 > --- a/drivers/infiniband/hw/qedr/verbs.c > +++ b/drivers/infiniband/hw/qedr/verbs.c > @@ -250,12 +250,6 @@ int qedr_query_port(struct ib_device *ibdev, u8 > port, struct ib_port_attr *attr) > return 0; > } > > -int qedr_modify_port(struct ib_device *ibdev, u8 port, int mask, > - struct ib_port_modify *props) > -{ > - return 0; > -} > - > static int qedr_add_mmap(struct qedr_ucontext *uctx, u64 phy_addr, > unsigned long len) > { > diff --git a/drivers/infiniband/hw/qedr/verbs.h > b/drivers/infiniband/hw/qedr/verbs.h > index 9aaa90283d6e..d81b81f86f0a 100644 > --- a/drivers/infiniband/hw/qedr/verbs.h > +++ b/drivers/infiniband/hw/qedr/verbs.h > @@ -35,8 +35,6 @@ > int qedr_query_device(struct ib_device *ibdev, > struct ib_device_attr *attr, struct ib_udata *udata); int > qedr_query_port(struct ib_device *, u8 port, struct ib_port_attr *props); -int > qedr_modify_port(struct ib_device *, u8 port, int mask, > - struct ib_port_modify *props); > > int qedr_iw_query_gid(struct ib_device *ibdev, u8 port, > int index, union ib_gid *gid); > -- > 2.20.1 Thanks, Acked-by: Michal Kalderon <michal.kalderon@marvell.com>
diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c index 5136b835e1ba..e5f36adb0120 100644 --- a/drivers/infiniband/hw/qedr/main.c +++ b/drivers/infiniband/hw/qedr/main.c @@ -212,7 +212,6 @@ static const struct ib_device_ops qedr_dev_ops = { .get_link_layer = qedr_link_layer, .map_mr_sg = qedr_map_mr_sg, .mmap = qedr_mmap, - .modify_port = qedr_modify_port, .modify_qp = qedr_modify_qp, .modify_srq = qedr_modify_srq, .poll_cq = qedr_poll_cq, diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c index 6f3ce86019b7..fee02ac47f32 100644 --- a/drivers/infiniband/hw/qedr/verbs.c +++ b/drivers/infiniband/hw/qedr/verbs.c @@ -250,12 +250,6 @@ int qedr_query_port(struct ib_device *ibdev, u8 port, struct ib_port_attr *attr) return 0; } -int qedr_modify_port(struct ib_device *ibdev, u8 port, int mask, - struct ib_port_modify *props) -{ - return 0; -} - static int qedr_add_mmap(struct qedr_ucontext *uctx, u64 phy_addr, unsigned long len) { diff --git a/drivers/infiniband/hw/qedr/verbs.h b/drivers/infiniband/hw/qedr/verbs.h index 9aaa90283d6e..d81b81f86f0a 100644 --- a/drivers/infiniband/hw/qedr/verbs.h +++ b/drivers/infiniband/hw/qedr/verbs.h @@ -35,8 +35,6 @@ int qedr_query_device(struct ib_device *ibdev, struct ib_device_attr *attr, struct ib_udata *udata); int qedr_query_port(struct ib_device *, u8 port, struct ib_port_attr *props); -int qedr_modify_port(struct ib_device *, u8 port, int mask, - struct ib_port_modify *props); int qedr_iw_query_gid(struct ib_device *ibdev, u8 port, int index, union ib_gid *gid);
There is no need to return always zero for function which is not supported. Fixes: ac1b36e55a51 ("qedr: Add support for user context verbs") Signed-off-by: Kamal Heib <kamalheib1@gmail.com> --- drivers/infiniband/hw/qedr/main.c | 1 - drivers/infiniband/hw/qedr/verbs.c | 6 ------ drivers/infiniband/hw/qedr/verbs.h | 2 -- 3 files changed, 9 deletions(-)