| Message ID | 20191028201032.6352-9-jgg@ziepe.ca (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Consolidate the mmu notifier interval_tree and locking | expand |
On Mon, Oct 28, 2019 at 05:10:25PM -0300, Jason Gunthorpe wrote: > From: Jason Gunthorpe <jgg@mellanox.com> > > DMA_SHARED_BUFFER can not be enabled by the user (it represents a library > set in the kernel). The kconfig convention is to use select for such > symbols so they are turned on implicitly when the user enables a kconfig > that needs them. > > Otherwise the XEN_GNTDEV_DMABUF kconfig is overly difficult to enable. > > Fixes: 932d6562179e ("xen/gntdev: Add initial support for dma-buf UAPI") > Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> > Cc: xen-devel@lists.xenproject.org > Cc: Juergen Gross <jgross@suse.com> > Cc: Stefano Stabellini <sstabellini@kernel.org> > Reviewed-by: Juergen Gross <jgross@suse.com> > Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> > Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> > --- > drivers/xen/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Juergen/Oleksandr/Xen Maintainers: Would you take this patch through a xen related tree? The only reason I had in this series is to make it easier to compile-test the gntdev changes. Since it is looking like the gntdev rework might not make it this cycle it is probably best for you to take it. Thanks, Jason
On 01.11.19 19:26, Jason Gunthorpe wrote: > On Mon, Oct 28, 2019 at 05:10:25PM -0300, Jason Gunthorpe wrote: >> From: Jason Gunthorpe <jgg@mellanox.com> >> >> DMA_SHARED_BUFFER can not be enabled by the user (it represents a library >> set in the kernel). The kconfig convention is to use select for such >> symbols so they are turned on implicitly when the user enables a kconfig >> that needs them. >> >> Otherwise the XEN_GNTDEV_DMABUF kconfig is overly difficult to enable. >> >> Fixes: 932d6562179e ("xen/gntdev: Add initial support for dma-buf UAPI") >> Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> >> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> >> Cc: xen-devel@lists.xenproject.org >> Cc: Juergen Gross <jgross@suse.com> >> Cc: Stefano Stabellini <sstabellini@kernel.org> >> Reviewed-by: Juergen Gross <jgross@suse.com> >> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> >> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> >> --- >> drivers/xen/Kconfig | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > Juergen/Oleksandr/Xen Maintainers: > > Would you take this patch through a xen related tree? The only reason > I had in this series is to make it easier to compile-test the gntdev > changes. Yes, I can take it for 5.5. Juergen
On 28.10.19 21:10, Jason Gunthorpe wrote: > From: Jason Gunthorpe <jgg@mellanox.com> > > DMA_SHARED_BUFFER can not be enabled by the user (it represents a library > set in the kernel). The kconfig convention is to use select for such > symbols so they are turned on implicitly when the user enables a kconfig > that needs them. > > Otherwise the XEN_GNTDEV_DMABUF kconfig is overly difficult to enable. > > Fixes: 932d6562179e ("xen/gntdev: Add initial support for dma-buf UAPI") > Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> > Cc: xen-devel@lists.xenproject.org > Cc: Juergen Gross <jgross@suse.com> > Cc: Stefano Stabellini <sstabellini@kernel.org> > Reviewed-by: Juergen Gross <jgross@suse.com> > Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> > Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> Applied to xen/tip.git for-linus-5.5a Juergen
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index 79cc75096f4232..a50dadd0109336 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -141,7 +141,8 @@ config XEN_GNTDEV config XEN_GNTDEV_DMABUF bool "Add support for dma-buf grant access device driver extension" - depends on XEN_GNTDEV && XEN_GRANT_DMA_ALLOC && DMA_SHARED_BUFFER + depends on XEN_GNTDEV && XEN_GRANT_DMA_ALLOC + select DMA_SHARED_BUFFER help Allows userspace processes and kernel modules to use Xen backed dma-buf implementation. With this extension grant references to