| Message ID | 20200204082408.18728-4-liweihang@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ib core support to send ib port link event | expand |
On Tue, Feb 04, 2020 at 04:24:04PM +0800, Weihang Li wrote: > From: Lang Cheng <chenglang@huawei.com> > > The qedr notify() will remove the processing of QEDE_UP and QEDE_DOWN, > so qede no more needs to notify rdma of these two events. > > Signed-off-by: Lang Cheng <chenglang@huawei.com> > drivers/net/ethernet/qlogic/qede/qede_rdma.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/net/ethernet/qlogic/qede/qede_rdma.c b/drivers/net/ethernet/qlogic/qede/qede_rdma.c > index ffabc2d..0493279 100644 > +++ b/drivers/net/ethernet/qlogic/qede/qede_rdma.c > @@ -145,8 +145,6 @@ void qede_rdma_dev_remove(struct qede_dev *edev, bool recovery) > > static void _qede_rdma_dev_open(struct qede_dev *edev) > { > - if (qedr_drv && edev->rdma_info.qedr_dev && qedr_drv->notify) > - qedr_drv->notify(edev->rdma_info.qedr_dev, QEDE_UP); > } > > static void qede_rdma_dev_open(struct qede_dev *edev) > @@ -161,8 +159,6 @@ static void qede_rdma_dev_open(struct qede_dev *edev) > > static void _qede_rdma_dev_close(struct qede_dev *edev) > { > - if (qedr_drv && edev->rdma_info.qedr_dev && qedr_drv->notify) > - qedr_drv->notify(edev->rdma_info.qedr_dev, QEDE_DOWN); > } Leaving empty functions behind? Why? I'm getting the feeling that this series is inside out or backwards something. This change should not happen until the rdma driver stops consuming these events Jason
On 2020/2/20 5:04, Jason Gunthorpe wrote: > On Tue, Feb 04, 2020 at 04:24:04PM +0800, Weihang Li wrote: >> From: Lang Cheng <chenglang@huawei.com> >> >> The qedr notify() will remove the processing of QEDE_UP and QEDE_DOWN, >> so qede no more needs to notify rdma of these two events. >> >> Signed-off-by: Lang Cheng <chenglang@huawei.com> >> drivers/net/ethernet/qlogic/qede/qede_rdma.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/drivers/net/ethernet/qlogic/qede/qede_rdma.c b/drivers/net/ethernet/qlogic/qede/qede_rdma.c >> index ffabc2d..0493279 100644 >> +++ b/drivers/net/ethernet/qlogic/qede/qede_rdma.c >> @@ -145,8 +145,6 @@ void qede_rdma_dev_remove(struct qede_dev *edev, bool recovery) >> >> static void _qede_rdma_dev_open(struct qede_dev *edev) >> { >> - if (qedr_drv && edev->rdma_info.qedr_dev && qedr_drv->notify) >> - qedr_drv->notify(edev->rdma_info.qedr_dev, QEDE_UP); >> } >> >> static void qede_rdma_dev_open(struct qede_dev *edev) >> @@ -161,8 +159,6 @@ static void qede_rdma_dev_open(struct qede_dev *edev) >> >> static void _qede_rdma_dev_close(struct qede_dev *edev) >> { >> - if (qedr_drv && edev->rdma_info.qedr_dev && qedr_drv->notify) >> - qedr_drv->notify(edev->rdma_info.qedr_dev, QEDE_DOWN); >> } > > Leaving empty functions behind? Why? Remove these empty static functions. > > I'm getting the feeling that this series is inside out or > backwards something. This change should not happen until the rdma > driver stops consuming these events > "RDMA/qedr: remove deliver net device event" should be in front of "qede: remove invalid notify operation". Exchange 3/7 and 4/7. thanks. > Jason >
diff --git a/drivers/net/ethernet/qlogic/qede/qede_rdma.c b/drivers/net/ethernet/qlogic/qede/qede_rdma.c index ffabc2d..0493279 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_rdma.c +++ b/drivers/net/ethernet/qlogic/qede/qede_rdma.c @@ -145,8 +145,6 @@ void qede_rdma_dev_remove(struct qede_dev *edev, bool recovery) static void _qede_rdma_dev_open(struct qede_dev *edev) { - if (qedr_drv && edev->rdma_info.qedr_dev && qedr_drv->notify) - qedr_drv->notify(edev->rdma_info.qedr_dev, QEDE_UP); } static void qede_rdma_dev_open(struct qede_dev *edev) @@ -161,8 +159,6 @@ static void qede_rdma_dev_open(struct qede_dev *edev) static void _qede_rdma_dev_close(struct qede_dev *edev) { - if (qedr_drv && edev->rdma_info.qedr_dev && qedr_drv->notify) - qedr_drv->notify(edev->rdma_info.qedr_dev, QEDE_DOWN); } static void qede_rdma_dev_close(struct qede_dev *edev)