diff mbox series

[for-next] RDMA/uverbs: Fix false error in query gid IOCTL

Message ID 20201026082621.32463-1-galpress@amazon.com (mailing list archive)
State Accepted
Delegated to: Jason Gunthorpe
Headers show
Series [for-next] RDMA/uverbs: Fix false error in query gid IOCTL | expand

Commit Message

Gal Pressman Oct. 26, 2020, 8:26 a.m. UTC 
Some drivers (such as EFA) have a GID table, but aren't IB/RoCE devices.
Remove the unnecessary rdma_ib_or_roce() check.

Fixes: 9f85cbe50aa0 ("RDMA/uverbs: Expose the new GID query API to user space")
Signed-off-by: Gal Pressman <galpress@amazon.com>
---
 drivers/infiniband/core/uverbs_std_types_device.c | 3 ---
 1 file changed, 3 deletions(-)


base-commit: c7a198c700763ac89abbb166378f546aeb9afb33

Comments

Jason Gunthorpe Oct. 26, 2020, 10:30 p.m. UTC | #1 
On Mon, Oct 26, 2020 at 10:26:21AM +0200, Gal Pressman wrote:
> Some drivers (such as EFA) have a GID table, but aren't IB/RoCE devices.
> Remove the unnecessary rdma_ib_or_roce() check.
> 
> Fixes: 9f85cbe50aa0 ("RDMA/uverbs: Expose the new GID query API to user space")
> Signed-off-by: Gal Pressman <galpress@amazon.com>
> ---
>  drivers/infiniband/core/uverbs_std_types_device.c | 3 ---
>  1 file changed, 3 deletions(-)

Applied to for-rc, thanks

Jason
diff mbox series

Patch

diff --git a/drivers/infiniband/core/uverbs_std_types_device.c b/drivers/infiniband/core/uverbs_std_types_device.c
index f367d523a46b..302f898c5833 100644
--- a/drivers/infiniband/core/uverbs_std_types_device.c
+++ b/drivers/infiniband/core/uverbs_std_types_device.c
@@ -401,9 +401,6 @@  static int UVERBS_HANDLER(UVERBS_METHOD_QUERY_GID_ENTRY)(
 	if (!rdma_is_port_valid(ib_dev, port_num))
 		return -EINVAL;
 
-	if (!rdma_ib_or_roce(ib_dev, port_num))
-		return -EOPNOTSUPP;
-
 	gid_attr = rdma_get_gid_attr(ib_dev, port_num, gid_index);
 	if (IS_ERR(gid_attr))
 		return PTR_ERR(gid_attr);