| Message ID | 20201226074248.2893-1-dinghao.liu@zju.edu.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | RDMA/usnic: Fix memleak in find_free_vf_and_create_qp_grp | expand |
On Sat, Dec 26, 2020 at 03:42:48PM +0800, Dinghao Liu wrote: > If usnic_ib_qp_grp_create() fails at the first call, dev_list > will not be freed on error, which leads to memleak. > > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> > --- > drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 3 +++ > 1 file changed, 3 insertions(+) > Fixes: e3cf00d0a87f ("IB/usnic: Add Cisco VIC low-level hardware driver") Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
On Sat, Dec 26, 2020 at 03:42:48PM +0800, Dinghao Liu wrote: > If usnic_ib_qp_grp_create() fails at the first call, dev_list > will not be freed on error, which leads to memleak. > > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> > Reviewed-by: Leon Romanovsky <leonro@nvidia.com> > --- > drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 3 +++ > 1 file changed, 3 insertions(+) Applied to for-rc with Fixes: e3cf00d0a87f ("IB/usnic: Add Cisco VIC low-level hardware driver") Thanks, Jason
diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index 38a37770c016..3705c6b8b223 100644 --- a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c +++ b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c @@ -214,6 +214,7 @@ find_free_vf_and_create_qp_grp(struct usnic_ib_dev *us_ibdev, } usnic_uiom_free_dev_list(dev_list); + dev_list = NULL; } /* Try to find resources on an unused vf */ @@ -239,6 +240,8 @@ find_free_vf_and_create_qp_grp(struct usnic_ib_dev *us_ibdev, qp_grp_check: if (IS_ERR_OR_NULL(qp_grp)) { usnic_err("Failed to allocate qp_grp\n"); + if (usnic_ib_share_vf) + usnic_uiom_free_dev_list(dev_list); return ERR_PTR(qp_grp ? PTR_ERR(qp_grp) : -ENOMEM); } return qp_grp;
If usnic_ib_qp_grp_create() fails at the first call, dev_list will not be freed on error, which leads to memleak. Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 3 +++ 1 file changed, 3 insertions(+)