| Message ID | 20210210075417.1096059-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [net-next] net/mlx5: SF, Fix error return code in mlx5_sf_dev_probe() | expand |
On Wed, Feb 10, 2021 at 07:54:17AM +0000, Wei Yongjun wrote: > Fix to return negative error code -ENOMEM from the ioremap() error > handling case instead of 0, as done elsewhere in this function. > > Fixes: 1958fc2f0712 ("net/mlx5: SF, Add auxiliary device driver") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > .../net/ethernet/mellanox/mlx5/core/sf/dev/driver.c | 1 + > 1 file changed, 1 insertion(+) > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
On Wed, 2021-02-10 at 10:03 +0200, Leon Romanovsky wrote: > On Wed, Feb 10, 2021 at 07:54:17AM +0000, Wei Yongjun wrote: > > Fix to return negative error code -ENOMEM from the ioremap() error > > handling case instead of 0, as done elsewhere in this function. > > > > Fixes: 1958fc2f0712 ("net/mlx5: SF, Add auxiliary device driver") > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > > --- > > .../net/ethernet/mellanox/mlx5/core/sf/dev/driver.c | 1 + > > 1 file changed, 1 insertion(+) > > > > Thanks, > Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Applied to net-next-mlx5, Thanks!
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/driver.c b/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/driver.c index daf63a8115e0..c4bf555c25ea 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/driver.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/driver.c @@ -37,6 +37,7 @@ static int mlx5_sf_dev_probe(struct auxiliary_device *adev, const struct auxilia mdev->iseg = ioremap(mdev->iseg_base, sizeof(*mdev->iseg)); if (!mdev->iseg) { mlx5_core_warn(mdev, "remap error\n"); + err = -ENOMEM; goto remap_err; }
Fix to return negative error code -ENOMEM from the ioremap() error handling case instead of 0, as done elsewhere in this function. Fixes: 1958fc2f0712 ("net/mlx5: SF, Add auxiliary device driver") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- .../net/ethernet/mellanox/mlx5/core/sf/dev/driver.c | 1 + 1 file changed, 1 insertion(+)