diff mbox series

[rdma-rc] RDMA/mlx5: Fix typo when prepare destroy_mkey inbox

Message ID 20210311142024.1282004-1-leon@kernel.org (mailing list archive)
State Accepted
Delegated to: Jason Gunthorpe
Headers show
Series [rdma-rc] RDMA/mlx5: Fix typo when prepare destroy_mkey inbox | expand

Commit Message

Leon Romanovsky March 11, 2021, 2:20 p.m. UTC
From: Mark Zhang <markzhang@nvidia.com>

Set mkey_index to correct place when prepare destroy_mkey inbox,
this will fix the following syndrome/

 mlx5_core 0000:08:00.0: mlx5_cmd_check:782:(pid 980716): DEALLOC_PD(0x801)
 op_mod(0x0) failed, status bad resource state(0x9), syndrome (0x31b635)

Cc: stable@vger.kernel.org
Fixes: 1368ead04c36 ("RDMA/mlx5: Use strict get/set operations for obj_id")
Reviewed-by: Ido Kalir <idok@mellanox.com>
Reviewed-by: Yishai Hadas <yishaih@nvidia.com>
Signed-off-by: Mark Zhang <markzhang@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
 drivers/infiniband/hw/mlx5/devx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.29.2

Comments

Jason Gunthorpe March 11, 2021, 5:37 p.m. UTC | #1
On Thu, Mar 11, 2021 at 04:20:24PM +0200, Leon Romanovsky wrote:
> From: Mark Zhang <markzhang@nvidia.com>
> 
> Set mkey_index to correct place when prepare destroy_mkey inbox,
> this will fix the following syndrome/
> 
>  mlx5_core 0000:08:00.0: mlx5_cmd_check:782:(pid 980716): DEALLOC_PD(0x801)
>  op_mod(0x0) failed, status bad resource state(0x9), syndrome (0x31b635)
> 
> Cc: stable@vger.kernel.org
> Fixes: 1368ead04c36 ("RDMA/mlx5: Use strict get/set operations for obj_id")
> Reviewed-by: Ido Kalir <idok@mellanox.com>
> Reviewed-by: Yishai Hadas <yishaih@nvidia.com>
> Signed-off-by: Mark Zhang <markzhang@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
>  drivers/infiniband/hw/mlx5/devx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-rc thanks

Jason
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/mlx5/devx.c b/drivers/infiniband/hw/mlx5/devx.c
index b78b5f18306d..3678b0a8710b 100644
--- a/drivers/infiniband/hw/mlx5/devx.c
+++ b/drivers/infiniband/hw/mlx5/devx.c
@@ -1116,7 +1116,7 @@  static void devx_obj_build_destroy_cmd(void *in, void *out, void *din,
 	case MLX5_CMD_OP_CREATE_MKEY:
 		MLX5_SET(destroy_mkey_in, din, opcode,
 			 MLX5_CMD_OP_DESTROY_MKEY);
-		MLX5_SET(destroy_mkey_in, in, mkey_index, *obj_id);
+		MLX5_SET(destroy_mkey_in, din, mkey_index, *obj_id);
 		break;
 	case MLX5_CMD_OP_CREATE_CQ:
 		MLX5_SET(destroy_cq_in, din, opcode, MLX5_CMD_OP_DESTROY_CQ);