| Message ID | 20210331135715.30072-1-bharat@chelsio.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [for-rc] RDMA/cxgb4: check for ipv6 address properly while destroying listener | expand |
On Wednesday, March 03/31/21, 2021 at 19:27:15 +0530, Potnuri Bharat Teja wrote: > ipv6 bit is wrongly set by commit '3408be145a5d' which causes fatal adapter > lookup engine errors for ipv4 connections while destroying listener. > Current patch properly checks the local address for ipv6 and fixes the > blunder introduced by commit '3408be145a5d'. > > Fixes: 3408be145a5d ("RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server") > Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com> Gentle reminder. > --- > drivers/infiniband/hw/cxgb4/cm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c > index 81903749d241..e42c812e74c3 100644 > --- a/drivers/infiniband/hw/cxgb4/cm.c > +++ b/drivers/infiniband/hw/cxgb4/cm.c > @@ -3616,7 +3616,8 @@ int c4iw_destroy_listen(struct iw_cm_id *cm_id) > c4iw_init_wr_wait(ep->com.wr_waitp); > err = cxgb4_remove_server( > ep->com.dev->rdev.lldi.ports[0], ep->stid, > - ep->com.dev->rdev.lldi.rxq_ids[0], true); > + ep->com.dev->rdev.lldi.rxq_ids[0], > + ep->com.local_addr.ss_family == AF_INET6); > if (err) > goto done; > err = c4iw_wait_for_reply(&ep->com.dev->rdev, ep->com.wr_waitp, > -- > 2.24.0 >
On Wed, Mar 31, 2021 at 07:27:15PM +0530, Potnuri Bharat Teja wrote: > ipv6 bit is wrongly set by commit '3408be145a5d' which causes fatal adapter > lookup engine errors for ipv4 connections while destroying listener. > Current patch properly checks the local address for ipv6 and fixes the > blunder introduced by commit '3408be145a5d'. > > Fixes: 3408be145a5d ("RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server") > Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com> > --- > drivers/infiniband/hw/cxgb4/cm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied to for-rc, thanks Jason
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index 81903749d241..e42c812e74c3 100644 --- a/drivers/infiniband/hw/cxgb4/cm.c +++ b/drivers/infiniband/hw/cxgb4/cm.c @@ -3616,7 +3616,8 @@ int c4iw_destroy_listen(struct iw_cm_id *cm_id) c4iw_init_wr_wait(ep->com.wr_waitp); err = cxgb4_remove_server( ep->com.dev->rdev.lldi.ports[0], ep->stid, - ep->com.dev->rdev.lldi.rxq_ids[0], true); + ep->com.dev->rdev.lldi.rxq_ids[0], + ep->com.local_addr.ss_family == AF_INET6); if (err) goto done; err = c4iw_wait_for_reply(&ep->com.dev->rdev, ep->com.wr_waitp,
ipv6 bit is wrongly set by commit '3408be145a5d' which causes fatal adapter lookup engine errors for ipv4 connections while destroying listener. Current patch properly checks the local address for ipv6 and fixes the blunder introduced by commit '3408be145a5d'. Fixes: 3408be145a5d ("RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server") Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com> --- drivers/infiniband/hw/cxgb4/cm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)