| Message ID | 20210726231009.24020-1-rpearsonhpe@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Leon Romanovsky |
| Headers | show |
| Series | [for-next] IB/core: Add xrc opcodes to ib_pack.h | expand |
On Mon, Jul 26, 2021 at 06:10:10PM -0500, Bob Pearson wrote: > ib_pack.h defines enums for all the RDMA opcodes except for the XRC > opcodes. This patch adds those opcodes. Why do we need such patch? What does it fix? What didn't work before? Thanks
On 7/27/21 5:43 AM, Leon Romanovsky wrote: > On Mon, Jul 26, 2021 at 06:10:10PM -0500, Bob Pearson wrote: >> ib_pack.h defines enums for all the RDMA opcodes except for the XRC >> opcodes. This patch adds those opcodes. > > Why do we need such patch? What does it fix? What didn't work before? > > Thanks > I'm working on implementing xrc for rxe. It uses the opcodes from ib_pack.h. So I have to either add the opcodes to ib_pack.h or redefine all the opcodes in the rxe driver. This seems like the better solution of the two. Bob
On Tue, Jul 27, 2021 at 06:23:48AM -0500, Bob Pearson wrote: > On 7/27/21 5:43 AM, Leon Romanovsky wrote: > > On Mon, Jul 26, 2021 at 06:10:10PM -0500, Bob Pearson wrote: > >> ib_pack.h defines enums for all the RDMA opcodes except for the XRC > >> opcodes. This patch adds those opcodes. > > > > Why do we need such patch? What does it fix? What didn't work before? > > > > Thanks > > > I'm working on implementing xrc for rxe. It uses the opcodes from ib_pack.h. So I have to either add the > opcodes to ib_pack.h or redefine all the opcodes in the rxe driver. > This seems like the better solution of the two. So please submit it together with your XRC series. Thanks > > Bob
diff --git a/include/rdma/ib_pack.h b/include/rdma/ib_pack.h index a9162f25beaf..afbf78a6669e 100644 --- a/include/rdma/ib_pack.h +++ b/include/rdma/ib_pack.h @@ -56,6 +56,7 @@ enum { IB_OPCODE_UD = 0x60, /* per IBTA 1.3 vol 1 Table 38, A10.3.2 */ IB_OPCODE_CNP = 0x80, + IB_OPCODE_XRC = 0xa0, /* Manufacturer specific */ IB_OPCODE_MSP = 0xe0, @@ -152,7 +153,32 @@ enum { /* UD */ IB_OPCODE(UD, SEND_ONLY), - IB_OPCODE(UD, SEND_ONLY_WITH_IMMEDIATE) + IB_OPCODE(UD, SEND_ONLY_WITH_IMMEDIATE), + + /* XRC */ + IB_OPCODE(XRC, SEND_FIRST), + IB_OPCODE(XRC, SEND_MIDDLE), + IB_OPCODE(XRC, SEND_LAST), + IB_OPCODE(XRC, SEND_LAST_WITH_IMMEDIATE), + IB_OPCODE(XRC, SEND_ONLY), + IB_OPCODE(XRC, SEND_ONLY_WITH_IMMEDIATE), + IB_OPCODE(XRC, RDMA_WRITE_FIRST), + IB_OPCODE(XRC, RDMA_WRITE_MIDDLE), + IB_OPCODE(XRC, RDMA_WRITE_LAST), + IB_OPCODE(XRC, RDMA_WRITE_LAST_WITH_IMMEDIATE), + IB_OPCODE(XRC, RDMA_WRITE_ONLY), + IB_OPCODE(XRC, RDMA_WRITE_ONLY_WITH_IMMEDIATE), + IB_OPCODE(XRC, RDMA_READ_REQUEST), + IB_OPCODE(XRC, RDMA_READ_RESPONSE_FIRST), + IB_OPCODE(XRC, RDMA_READ_RESPONSE_MIDDLE), + IB_OPCODE(XRC, RDMA_READ_RESPONSE_LAST), + IB_OPCODE(XRC, RDMA_READ_RESPONSE_ONLY), + IB_OPCODE(XRC, ACKNOWLEDGE), + IB_OPCODE(XRC, ATOMIC_ACKNOWLEDGE), + IB_OPCODE(XRC, COMPARE_SWAP), + IB_OPCODE(XRC, FETCH_ADD), + IB_OPCODE(XRC, SEND_LAST_WITH_INVALIDATE), + IB_OPCODE(XRC, SEND_ONLY_WITH_INVALIDATE) }; enum {
ib_pack.h defines enums for all the RDMA opcodes except for the XRC opcodes. This patch adds those opcodes. Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com> --- include/rdma/ib_pack.h | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-)