| Message ID | 20210816085531.12167-1-dinghao.liu@zju.edu.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | RDMA/bnxt_re: Remove redundant unlock in bnxt_re_dev_init | expand |
On Mon, Aug 16, 2021 at 2:26 PM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote: > > Commit c2b777a95923 removes all rtnl_lock() and rtnl_unlock() > in function bnxt_re_dev_init(), but forgets to remove a rtnl_unlock() > in the error handling path of bnxt_re_register_netdev(), which may > cause a deadlock. This bug is suggested by a static analysis tool, > please advise. > > Fixes: c2b777a95923 ("RDMA/bnxt_re: Refactor device add/remove functionalities") > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Acked-by: Selvin Xavier <selvin.xavier@broadcom.com>
On Mon, Aug 16, 2021 at 04:55:31PM +0800, Dinghao Liu wrote: > Commit c2b777a95923 removes all rtnl_lock() and rtnl_unlock() > in function bnxt_re_dev_init(), but forgets to remove a rtnl_unlock() > in the error handling path of bnxt_re_register_netdev(), which may > cause a deadlock. This bug is suggested by a static analysis tool, > please advise. > > Fixes: c2b777a95923 ("RDMA/bnxt_re: Refactor device add/remove functionalities") > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> > Acked-by: Selvin Xavier <selvin.xavier@broadcom.com> > --- > drivers/infiniband/hw/bnxt_re/main.c | 1 - > 1 file changed, 1 deletion(-) Applied to for-rc, thanks Jason
diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c index a8688a92c760..4678bd6ec7d6 100644 --- a/drivers/infiniband/hw/bnxt_re/main.c +++ b/drivers/infiniband/hw/bnxt_re/main.c @@ -1397,7 +1397,6 @@ static int bnxt_re_dev_init(struct bnxt_re_dev *rdev, u8 wqe_mode) memset(&rattr, 0, sizeof(rattr)); rc = bnxt_re_register_netdev(rdev); if (rc) { - rtnl_unlock(); ibdev_err(&rdev->ibdev, "Failed to register with netedev: %#x\n", rc); return -EINVAL;
Commit c2b777a95923 removes all rtnl_lock() and rtnl_unlock() in function bnxt_re_dev_init(), but forgets to remove a rtnl_unlock() in the error handling path of bnxt_re_register_netdev(), which may cause a deadlock. This bug is suggested by a static analysis tool, please advise. Fixes: c2b777a95923 ("RDMA/bnxt_re: Refactor device add/remove functionalities") Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> --- drivers/infiniband/hw/bnxt_re/main.c | 1 - 1 file changed, 1 deletion(-)