| Message ID | 20210922123341.601450-1-qtxuning1999@sjtu.edu.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | infiniband hfi1: fix misuse of %x in ipoib_tx.c | expand |
> Subject: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c > > Pointers should be printed with %p or %px rather than cast to (unsigned long > long) and printed with %llx. > Change %llx to %p to print the pointer. > > Signed-off-by: Guo Zhi <qtxuning1999@sjtu.edu.cn> > --- > drivers/infiniband/hw/hfi1/ipoib_tx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/infiniband/hw/hfi1/ipoib_tx.c > b/drivers/infiniband/hw/hfi1/ipoib_tx.c > index e74ddbe4658..7381f352311 100644 > --- a/drivers/infiniband/hw/hfi1/ipoib_tx.c > +++ b/drivers/infiniband/hw/hfi1/ipoib_tx.c > @@ -876,13 +876,13 @@ void hfi1_ipoib_tx_timeout(struct net_device > *dev, unsigned int q) > struct hfi1_ipoib_txq *txq = &priv->txqs[q]; > u64 completed = atomic64_read(&txq->complete_txreqs); > > - dd_dev_info(priv->dd, "timeout txq %llx q %u stopped %u stops %d > no_desc %d ring_full %d\n", > + dd_dev_info(priv->dd, "timeout txq %p q %u stopped %u stops %d > no_desc > +%d ring_full %d\n", > (unsigned long long)txq, q, > __netif_subqueue_stopped(dev, txq->q_idx), > atomic_read(&txq->stops), > atomic_read(&txq->no_desc), > atomic_read(&txq->ring_full)); > - dd_dev_info(priv->dd, "sde %llx engine %u\n", > + dd_dev_info(priv->dd, "sde %p engine %u\n", > (unsigned long long)txq->sde, Gho, As Denny mentioned, I'm assuming that the case is no longer required? Submit a v2 with that change and I will Ack. Mike
diff --git a/drivers/infiniband/hw/hfi1/ipoib_tx.c b/drivers/infiniband/hw/hfi1/ipoib_tx.c index e74ddbe4658..7381f352311 100644 --- a/drivers/infiniband/hw/hfi1/ipoib_tx.c +++ b/drivers/infiniband/hw/hfi1/ipoib_tx.c @@ -876,13 +876,13 @@ void hfi1_ipoib_tx_timeout(struct net_device *dev, unsigned int q) struct hfi1_ipoib_txq *txq = &priv->txqs[q]; u64 completed = atomic64_read(&txq->complete_txreqs); - dd_dev_info(priv->dd, "timeout txq %llx q %u stopped %u stops %d no_desc %d ring_full %d\n", + dd_dev_info(priv->dd, "timeout txq %p q %u stopped %u stops %d no_desc %d ring_full %d\n", (unsigned long long)txq, q, __netif_subqueue_stopped(dev, txq->q_idx), atomic_read(&txq->stops), atomic_read(&txq->no_desc), atomic_read(&txq->ring_full)); - dd_dev_info(priv->dd, "sde %llx engine %u\n", + dd_dev_info(priv->dd, "sde %p engine %u\n", (unsigned long long)txq->sde, txq->sde ? txq->sde->this_idx : 0); dd_dev_info(priv->dd, "flow %x\n", txq->flow.as_int);
Pointers should be printed with %p or %px rather than cast to (unsigned long long) and printed with %llx. Change %llx to %p to print the pointer. Signed-off-by: Guo Zhi <qtxuning1999@sjtu.edu.cn> --- drivers/infiniband/hw/hfi1/ipoib_tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)