mbox series

[pull-request] mlx5-next branch 2021-12-15

Message ID 20211215184945.185708-1-saeed@kernel.org (mailing list archive)
State Not Applicable
Headers show
Series [pull-request] mlx5-next branch 2021-12-15 | expand

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git mlx5-next

Message

Saeed Mahameed Dec. 15, 2021, 6:49 p.m. UTC
From: Saeed Mahameed <saeedm@nvidia.com>

Hi Dave, Jakub, Jason

This pulls mlx5-next branch into net-next and rdma branches.
All patches already reviewed on both rdma and netdev mailing lists.

Please pull and let me know if there's any problem.

1) Add multiple FDB steering priorities [1]
2) Introduce HW bits needed to configure MAC list size of VF/SF.
   Required for ("net/mlx5: Memory optimizations") upcoming series [2].

[1] https://lore.kernel.org/netdev/20211201193621.9129-1-saeed@kernel.org/
[2] https://lore.kernel.org/lkml/20211208141722.13646-1-shayd@nvidia.com/

Thanks,
Saeed.

The following changes since commit fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf:

  Linux 5.16-rc1 (2021-11-14 13:56:52 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git mlx5-next

for you to fetch changes up to 685b1afd7911676691c4167f420e16a957f5a38e:

  net/mlx5: Introduce log_max_current_uc_list_wr_supported bit (2021-12-15 10:21:50 -0800)

----------------------------------------------------------------
Maor Gottlieb (4):
      net/mlx5: Separate FDB namespace
      net/mlx5: Refactor mlx5_get_flow_namespace
      net/mlx5: Create more priorities for FDB bypass namespace
      RDMA/mlx5: Add support to multiple priorities for FDB rules

Shay Drory (1):
      net/mlx5: Introduce log_max_current_uc_list_wr_supported bit

 drivers/infiniband/hw/mlx5/fs.c                   | 18 +++++++++---------
 drivers/infiniband/hw/mlx5/mlx5_ib.h              |  3 ++-
 drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.c  |  4 +++-
 drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------
 include/linux/mlx5/fs.h                           |  1 +
 include/linux/mlx5/mlx5_ifc.h                     |  2 +-
 6 files changed, 76 insertions(+), 28 deletions(-)

Comments

Jakub Kicinski Dec. 15, 2021, 7:23 p.m. UTC | #1
On Wed, 15 Dec 2021 10:49:45 -0800 Saeed Mahameed wrote:
> This pulls mlx5-next branch into net-next and rdma branches.
> All patches already reviewed on both rdma and netdev mailing lists.
> 
> Please pull and let me know if there's any problem.
> 
> 1) Add multiple FDB steering priorities [1]
> 2) Introduce HW bits needed to configure MAC list size of VF/SF.
>    Required for ("net/mlx5: Memory optimizations") upcoming series [2].

Why are you not posting the patches?
Saeed Mahameed Dec. 15, 2021, 10:14 p.m. UTC | #2
On Wed, 2021-12-15 at 11:23 -0800, Jakub Kicinski wrote:
> On Wed, 15 Dec 2021 10:49:45 -0800 Saeed Mahameed wrote:
> > This pulls mlx5-next branch into net-next and rdma branches.
> > All patches already reviewed on both rdma and netdev mailing lists.
> > 
> > Please pull and let me know if there's any problem.
> > 
> > 1) Add multiple FDB steering priorities [1]
> > 2) Introduce HW bits needed to configure MAC list size of VF/SF.
> >    Required for ("net/mlx5: Memory optimizations") upcoming series
> > [2].
> 
> Why are you not posting the patches?

already posted before :
[1]
https://lore.kernel.org/netdev/20211201193621.9129-1-saeed@kernel.org/
[2]
https://lore.kernel.org/lkml/20211208141722.13646-1-shayd@nvidia.com/
Saeed Mahameed Dec. 15, 2021, 10:41 p.m. UTC | #3
On Wed, 2021-12-15 at 11:23 -0800, Jakub Kicinski wrote:
> On Wed, 15 Dec 2021 10:49:45 -0800 Saeed Mahameed wrote:
> > This pulls mlx5-next branch into net-next and rdma branches.
> > All patches already reviewed on both rdma and netdev mailing lists.
> > 
> > Please pull and let me know if there's any problem.
> > 
> > 1) Add multiple FDB steering priorities [1]
> > 2) Introduce HW bits needed to configure MAC list size of VF/SF.
> >    Required for ("net/mlx5: Memory optimizations") upcoming series
> > [2].
> 
> Why are you not posting the patches?

already posted before :
[1]
https://lore.kernel.org/netdev/20211201193621.9129-1-saeed@kernel.org/
[2]
https://lore.kernel.org/lkml/20211208141722.13646-1-shayd@nvidia.com/
Jakub Kicinski Dec. 15, 2021, 10:58 p.m. UTC | #4
On Wed, 15 Dec 2021 22:14:11 +0000 Saeed Mahameed wrote:
> On Wed, 2021-12-15 at 11:23 -0800, Jakub Kicinski wrote:
> > On Wed, 15 Dec 2021 10:49:45 -0800 Saeed Mahameed wrote:  
> > > This pulls mlx5-next branch into net-next and rdma branches.
> > > All patches already reviewed on both rdma and netdev mailing lists.
> > > 
> > > Please pull and let me know if there's any problem.
> > > 
> > > 1) Add multiple FDB steering priorities [1]
> > > 2) Introduce HW bits needed to configure MAC list size of VF/SF.
> > >    Required for ("net/mlx5: Memory optimizations") upcoming series
> > > [2].  
> > 
> > Why are you not posting the patches?  
> 
> already posted before :
> [1] https://lore.kernel.org/netdev/20211201193621.9129-1-saeed@kernel.org/
> [2] https://lore.kernel.org/lkml/20211208141722.13646-1-shayd@nvidia.com/

Post them as a reply to the pull request like you usually do, please.
Saeed Mahameed Dec. 15, 2021, 11:35 p.m. UTC | #5
On Wed, 2021-12-15 at 14:58 -0800, Jakub Kicinski wrote:
> On Wed, 15 Dec 2021 22:14:11 +0000 Saeed Mahameed wrote:
> > On Wed, 2021-12-15 at 11:23 -0800, Jakub Kicinski wrote:
> > > On Wed, 15 Dec 2021 10:49:45 -0800 Saeed Mahameed wrote:  
> > > > This pulls mlx5-next branch into net-next and rdma branches.
> > > > All patches already reviewed on both rdma and netdev mailing
> > > > lists.
> > > > 
> > > > Please pull and let me know if there's any problem.
> > > > 
> > > > 1) Add multiple FDB steering priorities [1]
> > > > 2) Introduce HW bits needed to configure MAC list size of
> > > > VF/SF.
> > > >    Required for ("net/mlx5: Memory optimizations") upcoming
> > > > series
> > > > [2].  
> > > 
> > > Why are you not posting the patches?  
> > 
> > already posted before :
> > [1]
> > https://lore.kernel.org/netdev/20211201193621.9129-1-saeed@kernel.org/
> > [2]
> > https://lore.kernel.org/lkml/20211208141722.13646-1-shayd@nvidia.com/
> 
> Post them as a reply to the pull request like you usually do, please.

They were already posted, and reviewed, and all maintainers were CC'ed,
including you, why do you want me to spam the mailing list over and
over again with the same patches ?  This is not how genuine pull
requests are supposed to work.
Jakub Kicinski Dec. 15, 2021, 11:44 p.m. UTC | #6
On Wed, 15 Dec 2021 15:35:09 -0800 Saeed Mahameed wrote:
> On Wed, 2021-12-15 at 14:58 -0800, Jakub Kicinski wrote:
> > On Wed, 15 Dec 2021 22:14:11 +0000 Saeed Mahameed wrote:  
> > > already posted before :
> > > [1] https://lore.kernel.org/netdev/20211201193621.9129-1-saeed@kernel.org/
> > > [2] https://lore.kernel.org/lkml/20211208141722.13646-1-shayd@nvidia.com/  
> > 
> > Post them as a reply to the pull request like you usually do, please.  
> 
> They were already posted, and reviewed, and all maintainers were CC'ed,
> including you, why do you want me to spam the mailing list over and
> over again with the same patches ?

You reposting measly 5 patches is hardly spamming. I have scripts which
check if the contents of the PR match the posting, which obviously
can't follow random links from the email.

> This is not how genuine pull requests are supposed to work.

I'm not comfortable with blindly pulling patches from vendor trees.
Saeed Mahameed Dec. 16, 2021, 12:55 a.m. UTC | #7
On Wed, 2021-12-15 at 15:44 -0800, Jakub Kicinski wrote:
> On Wed, 15 Dec 2021 15:35:09 -0800 Saeed Mahameed wrote:
> > On Wed, 2021-12-15 at 14:58 -0800, Jakub Kicinski wrote:
> > > On Wed, 15 Dec 2021 22:14:11 +0000 Saeed Mahameed wrote:  
> > > > already posted before :
> > > > [1] https://lore.kernel.org/netdev/20211201193621.9129-1-
> > > > saeed@kernel.org/
> > > > [2] https://lore.kernel.org/lkml/20211208141722.13646-1-
> > > > shayd@nvidia.com/ 
> > > 
> > > Post them as a reply to the pull request like you usually do,
> > > please.  
> > 
> > They were already posted, and reviewed, and all maintainers were
> > CC'ed,
> > including you, why do you want me to spam the mailing list over and
> > over again with the same patches ?
> 
> You reposting measly 5 patches is hardly spamming. I have scripts
> which

That's not the point, sometimes it is less or much more than 5.
For mlx5-next (Shared branch between RDMA and netdev), I would like to
submit standard clean PRs like all other maintainers.

> check if the contents of the PR match the posting, which obviously
> can't follow random links from the email.
> 

The script is great to validate pseudo-PRs (netdev only) where we post
patches for the first time in the PR.

but this is different, this is a true clean PR where all patches
already posted and reviewed. the tree is already written genuinely in
ink!

> > This is not how genuine pull requests are supposed to work.
> 
> I'm not comfortable with blindly pulling patches from vendor trees.

Good to know and very disappointing, is there anything i could do to
make you better trust my mlx5-next PRs ? other than RE-posting ?

Again I don't see any point of RE-posting the patches together with a
clean PR, redundant and unnecessary and against all standards, it just
cancels the whole process and duplicates my work, and will confuse
other maintainers who might have already pulled part or all of the
patches in the branch.