| Message ID | 20220307145047.3235675-2-cgxu519@mykernel.net (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [v2,1/2] RDMA/rxe: change variable and function argument to proper type | expand |
On Mon, Mar 07, 2022 at 10:50:47PM +0800, Chengguang Xu wrote: > The argument 'payload' is not used in update_state(), > so just remove it. > > Signed-off-by: Chengguang Xu <cgxu519@mykernel.net> > --- > drivers/infiniband/sw/rxe/rxe_req.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
On Mon, Mar 7, 2022 at 10:51 PM Chengguang Xu <cgxu519@mykernel.net> wrote: > > The argument 'payload' is not used in update_state(), > so just remove it. > > Signed-off-by: Chengguang Xu <cgxu519@mykernel.net> Acked-by: Zhu Yanjun <zyjzyj2000@gmail.com> Zhu Yanjun > --- > drivers/infiniband/sw/rxe/rxe_req.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c > index b28036a7a3b8..a3c78b4ac9f1 100644 > --- a/drivers/infiniband/sw/rxe/rxe_req.c > +++ b/drivers/infiniband/sw/rxe/rxe_req.c > @@ -540,7 +540,7 @@ static void rollback_state(struct rxe_send_wqe *wqe, > } > > static void update_state(struct rxe_qp *qp, struct rxe_send_wqe *wqe, > - struct rxe_pkt_info *pkt, u32 payload) > + struct rxe_pkt_info *pkt) > { > qp->req.opcode = pkt->opcode; > > @@ -747,7 +747,7 @@ int rxe_requester(void *arg) > goto err; > } > > - update_state(qp, wqe, &pkt, payload); > + update_state(qp, wqe, &pkt); > > goto next_wqe; > > -- > 2.27.0 > >
diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c index b28036a7a3b8..a3c78b4ac9f1 100644 --- a/drivers/infiniband/sw/rxe/rxe_req.c +++ b/drivers/infiniband/sw/rxe/rxe_req.c @@ -540,7 +540,7 @@ static void rollback_state(struct rxe_send_wqe *wqe, } static void update_state(struct rxe_qp *qp, struct rxe_send_wqe *wqe, - struct rxe_pkt_info *pkt, u32 payload) + struct rxe_pkt_info *pkt) { qp->req.opcode = pkt->opcode; @@ -747,7 +747,7 @@ int rxe_requester(void *arg) goto err; } - update_state(qp, wqe, &pkt, payload); + update_state(qp, wqe, &pkt); goto next_wqe;
The argument 'payload' is not used in update_state(), so just remove it. Signed-off-by: Chengguang Xu <cgxu519@mykernel.net> --- drivers/infiniband/sw/rxe/rxe_req.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)