| Message ID | 20220608005534.76789-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [-next] RDMA/erdma: remove unneeded semicolon | expand |
On 6/8/22 8:55 AM, Yang Li wrote: > Eliminate the following coccicheck warning: > ./drivers/infiniband/hw/erdma/erdma_qp.c:254:3-4: Unneeded semicolon > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Reviewed-by: Cheng Xu <chengyou@linux.alibaba.com> Thanks. Jason, BTW, are this and other two patches for erdma posted today parts of the static checker reports which you mentioned in [1] ? If so, I think I should re-post the v10 patches including the fixes ? Thanks, Cheng Xu [1] https://lore.kernel.org/linux-rdma/20220606154754.GA645238@nvidia.com/
On Wed, Jun 08, 2022 at 11:36:07AM +0800, Cheng Xu wrote: > > > On 6/8/22 8:55 AM, Yang Li wrote: > > Eliminate the following coccicheck warning: > > ./drivers/infiniband/hw/erdma/erdma_qp.c:254:3-4: Unneeded semicolon > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > > Reviewed-by: Cheng Xu <chengyou@linux.alibaba.com> > > Thanks. > > > Jason, > > BTW, are this and other two patches for erdma posted today parts of > the static checker reports which you mentioned in [1] ? If so, I think I > should re-post the v10 patches including the fixes ? Yes, the fixes need to be squashed into the relevant patches. Thanks > > Thanks, > Cheng Xu > > [1] https://lore.kernel.org/linux-rdma/20220606154754.GA645238@nvidia.com/
On 6/8/22 3:58 PM, Leon Romanovsky wrote: > On Wed, Jun 08, 2022 at 11:36:07AM +0800, Cheng Xu wrote: >> >> >> On 6/8/22 8:55 AM, Yang Li wrote: >>> Eliminate the following coccicheck warning: >>> ./drivers/infiniband/hw/erdma/erdma_qp.c:254:3-4: Unneeded semicolon >>> >>> Reported-by: Abaci Robot <abaci@linux.alibaba.com> >>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> >> >> Reviewed-by: Cheng Xu <chengyou@linux.alibaba.com> >> >> Thanks. >> >> >> Jason, >> >> BTW, are this and other two patches for erdma posted today parts of >> the static checker reports which you mentioned in [1] ? If so, I think I >> should re-post the v10 patches including the fixes ? > > Yes, the fixes need to be squashed into the relevant patches. > > Thanks > Get it, thanks. Cheng Xu >> >> Thanks, >> Cheng Xu >> >> [1] https://lore.kernel.org/linux-rdma/20220606154754.GA645238@nvidia.com/
On Wed, Jun 08, 2022 at 11:36:07AM +0800, Cheng Xu wrote: > > > On 6/8/22 8:55 AM, Yang Li wrote: > > Eliminate the following coccicheck warning: > > ./drivers/infiniband/hw/erdma/erdma_qp.c:254:3-4: Unneeded semicolon > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > > Reviewed-by: Cheng Xu <chengyou@linux.alibaba.com> > > Thanks. > > > Jason, > > BTW, are this and other two patches for erdma posted today parts of > the static checker reports which you mentioned in [1] ? If so, I think I > should re-post the v10 patches including the fixes ? Yes, and I would wait for a week or so because this is just the first day. Jason
diff --git a/drivers/infiniband/hw/erdma/erdma_qp.c b/drivers/infiniband/hw/erdma/erdma_qp.c index 6d49095662c8..a33b29ef11a5 100644 --- a/drivers/infiniband/hw/erdma/erdma_qp.c +++ b/drivers/infiniband/hw/erdma/erdma_qp.c @@ -251,7 +251,7 @@ static int fill_inline_data(struct erdma_qp *qp, qp->attrs.sq_size, SQEBB_SHIFT); if (!remain_size) break; - }; + } i++; }
Eliminate the following coccicheck warning: ./drivers/infiniband/hw/erdma/erdma_qp.c:254:3-4: Unneeded semicolon Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/infiniband/hw/erdma/erdma_qp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)