diff mbox series

[for-next,1/1] RDMA/irdma: One variable err is enough

Message ID 20230104064333.660344-1-yanjun.zhu@intel.com (mailing list archive)
State Accepted
Headers show
Series [for-next,1/1] RDMA/irdma: One variable err is enough | expand

Commit Message

Zhu Yanjun Jan. 4, 2023, 6:43 a.m. UTC 
From: Zhu Yanjun <yanjun.zhu@linux.dev>

In the function irdma_reg_user_mr, err and ret exist. Actually,
one variable err is enough.

Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
 drivers/infiniband/hw/irdma/verbs.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Leon Romanovsky Jan. 4, 2023, 7:02 a.m. UTC | #1 
On Wed, 4 Jan 2023 01:43:33 -0500, Zhu Yanjun wrote:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
> 
> In the function irdma_reg_user_mr, err and ret exist. Actually,
> one variable err is enough.
> 
> 

Applied, thanks!

[1/1] RDMA/irdma: One variable err is enough
      https://git.kernel.org/rdma/rdma/c/bd99ede8ef2dc0

Best regards,
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c
index f6973ea55eda..f4674ecf9c8c 100644
--- a/drivers/infiniband/hw/irdma/verbs.c
+++ b/drivers/infiniband/hw/irdma/verbs.c
@@ -2771,7 +2771,6 @@  static struct ib_mr *irdma_reg_user_mr(struct ib_pd *pd, u64 start, u64 len,
 	bool use_pbles = false;
 	unsigned long flags;
 	int err = -EINVAL;
-	int ret;
 
 	if (len > iwdev->rf->sc_dev.hw_attrs.max_mr_size)
 		return ERR_PTR(-EINVAL);
@@ -2871,9 +2870,9 @@  static struct ib_mr *irdma_reg_user_mr(struct ib_pd *pd, u64 start, u64 len,
 			goto error;
 
 		if (use_pbles) {
-			ret = irdma_check_mr_contiguous(palloc,
+			err = irdma_check_mr_contiguous(palloc,
 							iwmr->page_size);
-			if (ret) {
+			if (err) {
 				irdma_free_pble(iwdev->rf->pble_rsrc, palloc);
 				iwpbl->pbl_allocated = false;
 			}