| Message ID | 20230303124408.16685-1-n.petrova@fintech.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] rdmavt: delete unnecessary NULL check | expand |
On Fri, 03 Mar 2023 15:44:08 +0300, Natalia Petrova wrote: > There is no need to check 'rdi->qp_dev' for NULL. The field 'qp_dev' > is created in rvt_register_device() which will fail if the 'qp_dev' > allocation fails in rvt_driver_qp_init(). Overwise this pointer > doesn't changed and passed to rvt_qp_exit() by the next step. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > [...] Applied, thanks! [1/1] rdmavt: delete unnecessary NULL check https://git.kernel.org/rdma/rdma/c/9b3366ec12f0d7 Best regards,
diff --git a/drivers/infiniband/sw/rdmavt/qp.c b/drivers/infiniband/sw/rdmavt/qp.c index 3acab569fbb9..2bdc4486c3da 100644 --- a/drivers/infiniband/sw/rdmavt/qp.c +++ b/drivers/infiniband/sw/rdmavt/qp.c @@ -464,8 +464,6 @@ void rvt_qp_exit(struct rvt_dev_info *rdi) if (qps_inuse) rvt_pr_err(rdi, "QP memory leak! %u still in use\n", qps_inuse); - if (!rdi->qp_dev) - return; kfree(rdi->qp_dev->qp_table); free_qpn_table(&rdi->qp_dev->qpn_table);
There is no need to check 'rdi->qp_dev' for NULL. The field 'qp_dev' is created in rvt_register_device() which will fail if the 'qp_dev' allocation fails in rvt_driver_qp_init(). Overwise this pointer doesn't changed and passed to rvt_qp_exit() by the next step. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 0acb0cc7ecc1 ("IB/rdmavt: Initialize and teardown of qpn table") Signed-off-by: Natalia Petrova <n.petrova@fintech.ru> --- v2: The remark about non-null value of 'rdi->qp_dev' by Leon Romanovsky <leon@kernel.org> and Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com> was taken into account. drivers/infiniband/sw/rdmavt/qp.c | 2 -- 1 file changed, 2 deletions(-)