| Message ID | 20230613171654.19334-1-rpearsonhpe@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [v2,for-next] RDMA/rxe: Fixes mr access supported list | expand |
On Tue, Jun 13, 2023 at 12:16:55PM -0500, Bob Pearson wrote: > A recent patch incorrectly did not include IB_ACCESS_RELAXED_ORDERING > in the list of supported access flags for the rxe driver. The driver > actually does nothing related to relaxed ordering but it causes no > problems to include it as supported but with no effect. This change > caused ib_send_bw and friends to not run correctly. > > The correct approach is for the driver to allow any of the optional > access flags and otherwise ignore them. This patch adds > IB_ACCESS_OPTIONAL to the list of rxe supported flags. > > Link: https://lore.kernel.org/linux-rdma/ZIifmHzwnvn3YVbI@nvidia.com/raw > Fixes: 02ed253770fb ("RDMA/rxe: Introduce rxe access supported flags") > Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com> > --- > v2: Changed the target to for-next since the error is not currently in > for-rc. Replaced IB_ACCESS_RELAXED_ORDERING by IB_ACCESS_OPTIONAL > per a suggestion by Jason Gunthorpe. > --- > drivers/infiniband/sw/rxe/rxe_verbs.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied to for-next Thanks, Jason
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h index cb18b83b73c1..ccb9d19ffe8a 100644 --- a/drivers/infiniband/sw/rxe/rxe_verbs.h +++ b/drivers/infiniband/sw/rxe/rxe_verbs.h @@ -262,7 +262,8 @@ enum { | IB_ACCESS_MW_BIND | IB_ACCESS_ON_DEMAND | IB_ACCESS_FLUSH_GLOBAL - | IB_ACCESS_FLUSH_PERSISTENT, + | IB_ACCESS_FLUSH_PERSISTENT + | IB_ACCESS_OPTIONAL, RXE_ACCESS_SUPPORTED_QP = RXE_ACCESS_SUPPORTED_MR, RXE_ACCESS_SUPPORTED_MW = RXE_ACCESS_SUPPORTED_MR | IB_ZERO_BASED,
A recent patch incorrectly did not include IB_ACCESS_RELAXED_ORDERING in the list of supported access flags for the rxe driver. The driver actually does nothing related to relaxed ordering but it causes no problems to include it as supported but with no effect. This change caused ib_send_bw and friends to not run correctly. The correct approach is for the driver to allow any of the optional access flags and otherwise ignore them. This patch adds IB_ACCESS_OPTIONAL to the list of rxe supported flags. Link: https://lore.kernel.org/linux-rdma/ZIifmHzwnvn3YVbI@nvidia.com/raw Fixes: 02ed253770fb ("RDMA/rxe: Introduce rxe access supported flags") Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com> --- v2: Changed the target to for-next since the error is not currently in for-rc. Replaced IB_ACCESS_RELAXED_ORDERING by IB_ACCESS_OPTIONAL per a suggestion by Jason Gunthorpe. --- drivers/infiniband/sw/rxe/rxe_verbs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) base-commit: 830f93f47068b1632cc127871fbf27e918efdf46