| Message ID | 20230801123854.375155-1-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [net-next] net/mlx5: remove many unnecessary NULL values | expand |
On 8/1/2023 5:38 AM, Ruan Jinjie wrote: > Ther are many pointers assigned first, which need not to be initialized, so > remove the NULL assignment. > > Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> I went deep on this one and double checked all the changes, they're fine. Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
On Tue, Aug 01, 2023 at 08:38:54PM +0800, Ruan Jinjie wrote: > Ther are many pointers assigned first, which need not to be initialized, so Ther -> There > remove the NULL assignment. assignment -> assignments. > > Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c | 4 ++-- > drivers/net/ethernet/mellanox/mlx5/core/lib/hv_vhca.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
On 2023/8/4 2:17, Leon Romanovsky wrote: > On Tue, Aug 01, 2023 at 08:38:54PM +0800, Ruan Jinjie wrote: >> Ther are many pointers assigned first, which need not to be initialized, so > > Ther -> There > >> remove the NULL assignment. > > assignment -> assignments. Thank you! I'll fix the issues sooner. > >> >> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> >> --- >> drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c | 4 ++-- >> drivers/net/ethernet/mellanox/mlx5/core/lib/hv_vhca.c | 2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> > > Thanks, > Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c b/drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c index 39c03dcbd196..e5c1012921d2 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c @@ -57,7 +57,7 @@ static const char * const mlx5_fpga_qp_error_strings[] = { }; static struct mlx5_fpga_device *mlx5_fpga_device_alloc(void) { - struct mlx5_fpga_device *fdev = NULL; + struct mlx5_fpga_device *fdev; fdev = kzalloc(sizeof(*fdev), GFP_KERNEL); if (!fdev) @@ -252,7 +252,7 @@ int mlx5_fpga_device_start(struct mlx5_core_dev *mdev) int mlx5_fpga_init(struct mlx5_core_dev *mdev) { - struct mlx5_fpga_device *fdev = NULL; + struct mlx5_fpga_device *fdev; if (!MLX5_CAP_GEN(mdev, fpga)) { mlx5_core_dbg(mdev, "FPGA capability not present\n"); diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/hv_vhca.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/hv_vhca.c index 4047629a876b..30564d9b00e9 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/hv_vhca.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/hv_vhca.c @@ -40,7 +40,7 @@ struct mlx5_hv_vhca_agent { struct mlx5_hv_vhca *mlx5_hv_vhca_create(struct mlx5_core_dev *dev) { - struct mlx5_hv_vhca *hv_vhca = NULL; + struct mlx5_hv_vhca *hv_vhca; hv_vhca = kzalloc(sizeof(*hv_vhca), GFP_KERNEL); if (!hv_vhca)
Ther are many pointers assigned first, which need not to be initialized, so remove the NULL assignment. Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> --- drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c | 4 ++-- drivers/net/ethernet/mellanox/mlx5/core/lib/hv_vhca.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)