| Message ID | 20230905124048.284165-1-artem.chernyshev@red-soft.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] infiniband: cxgb4: cm: Check skb value | expand |
On Tue, 05 Sep 2023 15:40:48 +0300, Artem Chernyshev wrote: > get_skb() can't allocate skb in case of OOM. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Applied, thanks! [1/1] infiniband: cxgb4: cm: Check skb value https://git.kernel.org/rdma/rdma/c/8fb8a82086f5bd Best regards,
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index ced615b5ea09..54145b33a523 100644 --- a/drivers/infiniband/hw/cxgb4/cm.c +++ b/drivers/infiniband/hw/cxgb4/cm.c @@ -1965,6 +1965,8 @@ static int send_fw_act_open_req(struct c4iw_ep *ep, unsigned int atid) int win; skb = get_skb(NULL, sizeof(*req), GFP_KERNEL); + if (!skb) + return -ENOMEM; req = __skb_put_zero(skb, sizeof(*req)); req->op_compl = htonl(WR_OP_V(FW_OFLD_CONNECTION_WR)); req->len16_pkd = htonl(FW_WR_LEN16_V(DIV_ROUND_UP(sizeof(*req), 16)));
get_skb() can't allocate skb in case of OOM. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru> --- V2 -> remove pr_err drivers/infiniband/hw/cxgb4/cm.c | 2 ++ 1 file changed, 2 insertions(+)