| Message ID | 20231013020053.2120-21-guoqing.jiang@linux.dev (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Cleanup for siw | expand |
> -----Original Message----- > From: Guoqing Jiang <guoqing.jiang@linux.dev> > Sent: Friday, October 13, 2023 4:01 AM > To: Bernard Metzler <BMT@zurich.ibm.com>; jgg@ziepe.ca; leon@kernel.org > Cc: linux-rdma@vger.kernel.org > Subject: [EXTERNAL] [PATCH V2 20/20] RDMA/siw: Update comments for > siw_qp_sq_process > > There is no siw_sq_work_handler in code, change it with siw_tx_thread > since siw_run_sq -> siw_sq_resume -> siw_qp_sq_process. > > Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev> > --- > drivers/infiniband/sw/siw/siw_qp_tx.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/infiniband/sw/siw/siw_qp_tx.c > b/drivers/infiniband/sw/siw/siw_qp_tx.c > index 2e055b6dcd42..553d85cb6dbb 100644 > --- a/drivers/infiniband/sw/siw/siw_qp_tx.c > +++ b/drivers/infiniband/sw/siw/siw_qp_tx.c > @@ -1001,13 +1001,12 @@ static int siw_qp_sq_proc_local(struct siw_qp *qp, > struct siw_wqe *wqe) > * MPA FPDUs, each containing a DDP segment. > * > * SQ processing may occur in user context as a result of posting > - * new WQE's or from siw_sq_work_handler() context. Processing in > + * new WQE's or from siw_tx_thread context. Processing in > * user context is limited to non-kernel verbs users. > * > * SQ processing may get paused anytime, possibly in the middle of a WR > * or FPDU, if insufficient send space is available. SQ processing > - * gets resumed from siw_sq_work_handler(), if send space becomes > - * available again. > + * gets resumed from siw_tx_thread, if send space becomes available again. > * > * Must be called with the QP state read-locked. > * > -- > 2.35.3 Thanks, makes sense! Acked-by: Bernard Metzler <bmt@zurich.ibm.com>
diff --git a/drivers/infiniband/sw/siw/siw_qp_tx.c b/drivers/infiniband/sw/siw/siw_qp_tx.c index 2e055b6dcd42..553d85cb6dbb 100644 --- a/drivers/infiniband/sw/siw/siw_qp_tx.c +++ b/drivers/infiniband/sw/siw/siw_qp_tx.c @@ -1001,13 +1001,12 @@ static int siw_qp_sq_proc_local(struct siw_qp *qp, struct siw_wqe *wqe) * MPA FPDUs, each containing a DDP segment. * * SQ processing may occur in user context as a result of posting - * new WQE's or from siw_sq_work_handler() context. Processing in + * new WQE's or from siw_tx_thread context. Processing in * user context is limited to non-kernel verbs users. * * SQ processing may get paused anytime, possibly in the middle of a WR * or FPDU, if insufficient send space is available. SQ processing - * gets resumed from siw_sq_work_handler(), if send space becomes - * available again. + * gets resumed from siw_tx_thread, if send space becomes available again. * * Must be called with the QP state read-locked. *
There is no siw_sq_work_handler in code, change it with siw_tx_thread since siw_run_sq -> siw_sq_resume -> siw_qp_sq_process. Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev> --- drivers/infiniband/sw/siw/siw_qp_tx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)