diff mbox series

[v3,rdma-next,2/7] RDMA/mlx5: Obtain upper net device only when needed

Message ID 20240909173025.30422-3-michaelgur@nvidia.com (mailing list archive)
State Accepted
Headers show
Series Support RDMA events monitoring through | expand

Commit Message

Michael Guralnik Sept. 9, 2024, 5:30 p.m. UTC
From: Mark Bloch <mbloch@nvidia.com>

Report the upper device's state as the RDMA port state only in RoCE LAG or
switchdev LAG.

Fixes: 27f9e0ccb6da ("net/mlx5: Lag, Add single RDMA device in multiport mode")
Signed-off-by: Mark Bloch <mbloch@nvidia.com>
Signed-off-by: Michael Guralnik <michaelgur@nvidia.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
---
 drivers/infiniband/hw/mlx5/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalesh Anakkur Purayil Sept. 10, 2024, 3:59 a.m. UTC | #1
On Mon, Sep 9, 2024 at 11:10 PM Michael Guralnik <michaelgur@nvidia.com> wrote:
>
> From: Mark Bloch <mbloch@nvidia.com>
>
> Report the upper device's state as the RDMA port state only in RoCE LAG or
> switchdev LAG.
>
> Fixes: 27f9e0ccb6da ("net/mlx5: Lag, Add single RDMA device in multiport mode")
> Signed-off-by: Mark Bloch <mbloch@nvidia.com>
> Signed-off-by: Michael Guralnik <michaelgur@nvidia.com>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Looks good to me
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> ---
>  drivers/infiniband/hw/mlx5/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
> index cdf1ce0f6b34..c75cc3d14e74 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -558,7 +558,7 @@ static int mlx5_query_port_roce(struct ib_device *device, u32 port_num,
>         if (!ndev)
>                 goto out;
>
> -       if (dev->lag_active) {
> +       if (mlx5_lag_is_roce(mdev) || mlx5_lag_is_sriov(mdev)) {
>                 rcu_read_lock();
>                 upper = netdev_master_upper_dev_get_rcu(ndev);
>                 if (upper) {
> --
> 2.17.2
>
>
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index cdf1ce0f6b34..c75cc3d14e74 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -558,7 +558,7 @@  static int mlx5_query_port_roce(struct ib_device *device, u32 port_num,
 	if (!ndev)
 		goto out;
 
-	if (dev->lag_active) {
+	if (mlx5_lag_is_roce(mdev) || mlx5_lag_is_sriov(mdev)) {
 		rcu_read_lock();
 		upper = netdev_master_upper_dev_get_rcu(ndev);
 		if (upper) {