diff mbox series

IB/hfi1: make clear_all_interrupts static

Message ID 20241007235327.128613-1-linux@treblig.org (mailing list archive)
State Accepted
Headers show
Series IB/hfi1: make clear_all_interrupts static | expand

Commit Message

Dr. David Alan Gilbert Oct. 7, 2024, 11:53 p.m. UTC 
From: "Dr. David Alan Gilbert" <linux@treblig.org>

clear_all_interrupts() in hw/hfi1/chip.c is currently global
but only used in the same file, so make it static.

There are also 'clear_all_interrupts' functions in i2c-nomadik and
emif.c but fortunately they're already static.

(Build and boot tested only, I don't have this hardware)

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/infiniband/hw/hfi1/chip.c | 2 +-
 drivers/infiniband/hw/hfi1/chip.h | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

Comments

Leon Romanovsky Oct. 8, 2024, 7:49 a.m. UTC | #1 
On Tue, 08 Oct 2024 00:53:26 +0100, linux@treblig.org wrote:
> clear_all_interrupts() in hw/hfi1/chip.c is currently global
> but only used in the same file, so make it static.
> 
> There are also 'clear_all_interrupts' functions in i2c-nomadik and
> emif.c but fortunately they're already static.
> 
> (Build and boot tested only, I don't have this hardware)
> 
> [...]

Applied, thanks!

[1/1] IB/hfi1: make clear_all_interrupts static
      https://git.kernel.org/rdma/rdma/c/89e9ae55dc56f3

Best regards,
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/hfi1/chip.c b/drivers/infiniband/hw/hfi1/chip.c
index c52e6b2c9914..a442eca498b8 100644
--- a/drivers/infiniband/hw/hfi1/chip.c
+++ b/drivers/infiniband/hw/hfi1/chip.c
@@ -13235,7 +13235,7 @@  int set_intr_bits(struct hfi1_devdata *dd, u16 first, u16 last, bool set)
 /*
  * Clear all interrupt sources on the chip.
  */
-void clear_all_interrupts(struct hfi1_devdata *dd)
+static void clear_all_interrupts(struct hfi1_devdata *dd)
 {
 	int i;
 
diff --git a/drivers/infiniband/hw/hfi1/chip.h b/drivers/infiniband/hw/hfi1/chip.h
index d861aa8fc640..8841db16bde7 100644
--- a/drivers/infiniband/hw/hfi1/chip.h
+++ b/drivers/infiniband/hw/hfi1/chip.h
@@ -1404,7 +1404,6 @@  irqreturn_t receive_context_interrupt_napi(int irq, void *data);
 
 int set_intr_bits(struct hfi1_devdata *dd, u16 first, u16 last, bool set);
 void init_qsfp_int(struct hfi1_devdata *dd);
-void clear_all_interrupts(struct hfi1_devdata *dd);
 void remap_intr(struct hfi1_devdata *dd, int isrc, int msix_intr);
 void remap_sdma_interrupts(struct hfi1_devdata *dd, int engine, int msix_intr);
 void reset_interrupts(struct hfi1_devdata *dd);