| Message ID | 24b6074a-f678-c367-484b-e16a0c1f9b5f@users.sourceforge.net (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
Acked-By: Devesh Sharma <devesh.sharma@broadcom.com> On Wed, Mar 8, 2017 at 6:52 PM, SF Markus Elfring <elfring@users.sourceforge.net> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Wed, 8 Mar 2017 10:00:41 +0100 > > Delete an assignment for the local variable "status" in an if branch > because the desired failure indication is already specified by a constant > error code at the end. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > index 05d55d361cfe..af8798fd35b1 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > @@ -3031,10 +3031,8 @@ struct ib_mr *ocrdma_alloc_mr(struct ib_pd *ibpd, > return ERR_PTR(-ENOMEM); > > mr->pages = kcalloc(max_num_sg, sizeof(*mr->pages), GFP_KERNEL); > - if (!mr->pages) { > - status = -ENOMEM; > + if (!mr->pages) > goto pl_err; > - } > > status = ocrdma_get_pbl_info(dev, mr, max_num_sg); > if (status) > -- > 2.12.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Mar 08, 2017 at 02:22:21PM +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Wed, 8 Mar 2017 10:00:41 +0100 > > Delete an assignment for the local variable "status" in an if branch > because the desired failure indication is already specified by a constant > error code at the end. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > index 05d55d361cfe..af8798fd35b1 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > @@ -3031,10 +3031,8 @@ struct ib_mr *ocrdma_alloc_mr(struct ib_pd *ibpd, > return ERR_PTR(-ENOMEM); > > mr->pages = kcalloc(max_num_sg, sizeof(*mr->pages), GFP_KERNEL); > - if (!mr->pages) { > - status = -ENOMEM; > + if (!mr->pages) > goto pl_err; > - } > Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> > status = ocrdma_get_pbl_info(dev, mr, max_num_sg); > if (status) > -- > 2.12.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c index 05d55d361cfe..af8798fd35b1 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c @@ -3031,10 +3031,8 @@ struct ib_mr *ocrdma_alloc_mr(struct ib_pd *ibpd, return ERR_PTR(-ENOMEM); mr->pages = kcalloc(max_num_sg, sizeof(*mr->pages), GFP_KERNEL); - if (!mr->pages) { - status = -ENOMEM; + if (!mr->pages) goto pl_err; - } status = ocrdma_get_pbl_info(dev, mr, max_num_sg); if (status)