| Message ID | 3f13d926-d132-4463-ac38-f6e6ef3501c6@CMEXHTCAS2.ad.emulex.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index dab4b41..7f8ee93 100644 --- a/drivers/infiniband/core/cma.c +++ b/drivers/infiniband/core/cma.c @@ -2466,8 +2466,11 @@ static int cma_check_linklocal(struct rdma_dev_addr *dev_addr, return 0; sin6 = (struct sockaddr_in6 *) addr; - if ((ipv6_addr_type(&sin6->sin6_addr) & IPV6_ADDR_LINKLOCAL) && - !sin6->sin6_scope_id) + + if (!(ipv6_addr_type(&sin6->sin6_addr) & IPV6_ADDR_LINKLOCAL)) + return 0; + + if (!sin6->sin6_scope_id) return -EINVAL; dev_addr->bound_dev_if = sin6->sin6_scope_id;
Even if the addr is not a linklocal address, the code treats it as such and assigns the bound dev addr to the scope id of the address which is invalid. Fix by checking if it's a link local address first and return 0 if not. Signed-off-by: Somnath Kotur <somnath.kotur@emulex.com> --- drivers/infiniband/core/cma.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-)