| Message ID | 499f1d77-7da6-2c00-e826-bf4d0809f48a@dev.mellanox.co.il (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Ira Weiny |
| Headers | show |
On Mon, Dec 11, 2017 at 09:57:23AM -0500, Hal Rosenstock wrote: > > Signed-off-by: Hal Rosenstock <hal@mellanox.com> > --- > src/smpdump.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/smpdump.c b/src/smpdump.c > index bc8559a..bb304d4 100644 > --- a/src/smpdump.c > +++ b/src/smpdump.c > @@ -281,6 +281,8 @@ int main(int argc, char *argv[]) > if (umad_recv(portid, umad, &length, -1) != mad_agent) > IBPANIC("recv error: %s", strerror(errno)); > > + printf("%d bytes received\n", length); This seems like it is more for debugging. How will this affect any scripts which include this command? Should we make this debug output? Ira > + > if (!dump_char) { > xdump(stdout, 0, smp->data, 64); > if (smp->status) > -- > 2.8.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2/7/2018 12:35 AM, ira.weiny wrote: > On Mon, Dec 11, 2017 at 09:57:23AM -0500, Hal Rosenstock wrote: >> >> Signed-off-by: Hal Rosenstock <hal@mellanox.com> >> --- >> src/smpdump.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/src/smpdump.c b/src/smpdump.c >> index bc8559a..bb304d4 100644 >> --- a/src/smpdump.c >> +++ b/src/smpdump.c >> @@ -281,6 +281,8 @@ int main(int argc, char *argv[]) >> if (umad_recv(portid, umad, &length, -1) != mad_agent) >> IBPANIC("recv error: %s", strerror(errno)); >> >> + printf("%d bytes received\n", length); > > This seems like it is more for debugging. I don't recall now what the case was exactly where umad_recv succeeded but it was unclear whether the data was valid or not. In that sense, it's a missing part of the current information returned. I think this command geared at manual debug of attribute IDs not supported in smpquery. > How will this affect any scripts which include this command? AFAIK there are no such scripts. > Should we make this debug output? That's probably better/safer and at least provides a way to obtain the proposed added information. Do you want an updated patch for this ? -- Hal > Ira > > >> + >> if (!dump_char) { >> xdump(stdout, 0, smp->data, 64); >> if (smp->status) >> -- >> 2.8.4 >> > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
PiANCj4gT24gMi83LzIwMTggMTI6MzUgQU0sIGlyYS53ZWlueSB3cm90ZToNCj4gPiBPbiBNb24s IERlYyAxMSwgMjAxNyBhdCAwOTo1NzoyM0FNIC0wNTAwLCBIYWwgUm9zZW5zdG9jayB3cm90ZToN Cj4gPj4NCj4gPj4gU2lnbmVkLW9mZi1ieTogSGFsIFJvc2Vuc3RvY2sgPGhhbEBtZWxsYW5veC5j b20+DQo+ID4+IC0tLQ0KPiA+PiAgc3JjL3NtcGR1bXAuYyB8IDIgKysNCj4gPj4gIDEgZmlsZSBj aGFuZ2VkLCAyIGluc2VydGlvbnMoKykNCj4gPj4NCj4gPj4gZGlmZiAtLWdpdCBhL3NyYy9zbXBk dW1wLmMgYi9zcmMvc21wZHVtcC5jIGluZGV4IGJjODU1OWEuLmJiMzA0ZDQNCj4gPj4gMTAwNjQ0 DQo+ID4+IC0tLSBhL3NyYy9zbXBkdW1wLmMNCj4gPj4gKysrIGIvc3JjL3NtcGR1bXAuYw0KPiA+ PiBAQCAtMjgxLDYgKzI4MSw4IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pDQo+ ID4+ICAJaWYgKHVtYWRfcmVjdihwb3J0aWQsIHVtYWQsICZsZW5ndGgsIC0xKSAhPSBtYWRfYWdl bnQpDQo+ID4+ICAJCUlCUEFOSUMoInJlY3YgZXJyb3I6ICVzIiwgc3RyZXJyb3IoZXJybm8pKTsN Cj4gPj4NCj4gPj4gKwlwcmludGYoIiVkIGJ5dGVzIHJlY2VpdmVkXG4iLCBsZW5ndGgpOw0KPiA+ DQo+ID4gVGhpcyBzZWVtcyBsaWtlIGl0IGlzIG1vcmUgZm9yIGRlYnVnZ2luZy4NCj4gDQo+IEkg ZG9uJ3QgcmVjYWxsIG5vdyB3aGF0IHRoZSBjYXNlIHdhcyBleGFjdGx5IHdoZXJlIHVtYWRfcmVj diBzdWNjZWVkZWQgYnV0IGl0DQo+IHdhcyB1bmNsZWFyIHdoZXRoZXIgdGhlIGRhdGEgd2FzIHZh bGlkIG9yIG5vdC4gSW4gdGhhdCBzZW5zZSwgaXQncyBhIG1pc3NpbmcgcGFydCBvZg0KPiB0aGUg Y3VycmVudCBpbmZvcm1hdGlvbiByZXR1cm5lZC4NCj4gDQo+IEkgdGhpbmsgdGhpcyBjb21tYW5k IGdlYXJlZCBhdCBtYW51YWwgZGVidWcgb2YgYXR0cmlidXRlIElEcyBub3Qgc3VwcG9ydGVkIGlu DQo+IHNtcHF1ZXJ5Lg0KPiANCj4gPiBIb3cgd2lsbCB0aGlzIGFmZmVjdCBhbnkgc2NyaXB0cyB3 aGljaCBpbmNsdWRlIHRoaXMgY29tbWFuZD8NCj4gDQo+IEFGQUlLIHRoZXJlIGFyZSBubyBzdWNo IHNjcmlwdHMuDQo+IA0KPiA+IFNob3VsZCB3ZSBtYWtlIHRoaXMgZGVidWcgb3V0cHV0Pw0KPiAN Cj4gVGhhdCdzIHByb2JhYmx5IGJldHRlci9zYWZlciBhbmQgYXQgbGVhc3QgcHJvdmlkZXMgYSB3 YXkgdG8gb2J0YWluIHRoZSBwcm9wb3NlZA0KPiBhZGRlZCBpbmZvcm1hdGlvbi4NCj4gDQo+IERv IHlvdSB3YW50IGFuIHVwZGF0ZWQgcGF0Y2ggZm9yIHRoaXMgPw0KDQpZZXMgcGxlYXNlLA0KSXJh DQoNCg0K -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/src/smpdump.c b/src/smpdump.c index bc8559a..bb304d4 100644 --- a/src/smpdump.c +++ b/src/smpdump.c @@ -281,6 +281,8 @@ int main(int argc, char *argv[]) if (umad_recv(portid, umad, &length, -1) != mad_agent) IBPANIC("recv error: %s", strerror(errno)); + printf("%d bytes received\n", length); + if (!dump_char) { xdump(stdout, 0, smp->data, 64); if (smp->status)
Signed-off-by: Hal Rosenstock <hal@mellanox.com> --- src/smpdump.c | 2 ++ 1 file changed, 2 insertions(+)