diff mbox

opensm/complib/cl_atomic_osd.h: Fix long standing bug in cl_atomic_sub

Message ID 5087F029.7070200@dev.mellanox.co.il (mailing list archive)
State Rejected
Delegated to: Alex Netes
Headers show

Commit Message

Hal Rosenstock Oct. 24, 2012, 1:42 p.m. UTC
Should subtract rather than add decrement
Routine was same as cl_atomic_add other than parameter name
being decrement instead of increment so assume this is
cut 'n paste error
Nothing in opensm used this routine up to now

Signed-off-by: Hal Rosenstock <hal@mellanox.com>
---
 include/complib/cl_atomic_osd.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff mbox

Patch

diff --git a/include/complib/cl_atomic_osd.h b/include/complib/cl_atomic_osd.h
index 4df9618..822c19d 100644
--- a/include/complib/cl_atomic_osd.h
+++ b/include/complib/cl_atomic_osd.h
@@ -96,7 +96,7 @@  cl_atomic_sub(IN atomic32_t * const p_value, IN const int32_t decrement)
 	int32_t new_val;
 
 	cl_spinlock_acquire(&cl_atomic_spinlock);
-	new_val = *p_value + decrement;
+	new_val = *p_value - decrement;
 	*p_value = new_val;
 	cl_spinlock_release(&cl_atomic_spinlock);
 	return (new_val);