diff mbox

[v2,opensm] osm_subnet.c: Enhance opensm conf file documentation for PerfMgr options

Message ID 536A771D.20602@dev.mellanox.co.il (mailing list archive)
State Accepted
Delegated to: Hal Rosenstock
Headers show

Commit Message

Hal Rosenstock May 7, 2014, 6:10 p.m. UTC 
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Hal Rosenstock <hal@mellanox.com>
---
Change from version 1:
Formatted properly for posting to linux-rdma

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c
index f30d852..8ee62d9 100644
--- a/opensm/osm_subnet.c
+++ b/opensm/osm_subnet.c
@@ -2628,28 +2628,35 @@  int osm_subn_output_conf(FILE *out, IN osm_subn_opt_t * p_opts)
 	fprintf(out,
 		"#\n# Performance Manager Options\n#\n"
 		"# perfmgr enable\n"
+		"# PerfMgr is enabled if TRUE and disabled if FALSE (default FALSE)\n"
 		"perfmgr %s\n\n"
-		"# perfmgr redirection enable\n"
+		"# redirection enable\n"
+		"# Redirection supported if TRUE and not supported if FALSE (default TRUE)\n"
 		"perfmgr_redir %s\n\n"
-		"# sweep time in seconds\n"
+		"# sweep time in seconds (default %u seconds)\n"
 		"perfmgr_sweep_time_s %u\n\n"
-		"# Max outstanding queries\n"
+		"# Max outstanding queries (default %u)\n"
 		"perfmgr_max_outstanding_queries %u\n"
+		"# Ignore CAs on sweep (default FALSE)\n"
 		"perfmgr_ignore_cas %s\n\n"
-		"# Remove missing nodes from DB\n"
+		"# Remove missing nodes from DB (default TRUE)\n"
 		"perfmgr_rm_nodes %s\n\n"
-		"# Log error counters to opensm.log\n"
+		"# Log error counters to opensm.log (default TRUE)\n"
 		"perfmgr_log_errors %s\n\n"
 		"# Query PerfMgrGet(ClassPortInfo) for extended capabilities\n"
+		"# Extended capabilities include 64 bit extended counters and transmit wait support\n"
+		"# default FALSE\n"
 		"perfmgr_query_cpi %s\n\n"
-		"# Log xmit_wait errors\n"
+		"# Log xmit_wait errors (default FALSE)\n"
 		"perfmgr_xmit_wait_log %s\n\n"
 		"# If logging xmit_wait's; set threshold (default %u)\n"
 		"perfmgr_xmit_wait_threshold %u\n\n"
 		,
 		p_opts->perfmgr ? "TRUE" : "FALSE",
 		p_opts->perfmgr_redir ? "TRUE" : "FALSE",
+		OSM_PERFMGR_DEFAULT_SWEEP_TIME_S,
 		p_opts->perfmgr_sweep_time_s,
+		OSM_PERFMGR_DEFAULT_MAX_OUTSTANDING_QUERIES,
 		p_opts->perfmgr_max_outstanding_queries,
 		p_opts->perfmgr_ignore_cas ? "TRUE" : "FALSE",
 		p_opts->perfmgr_rm_nodes ? "TRUE" : "FALSE",