rmmod mlx4_core panic 3.16-rc1

Commit Message

Or Gerlitz June 22, 2014, 9:29 a.m. UTC

On 20/06/2014 20:15, Shirley Ma wrote:
>
> On 06/19/2014 08:34 PM, Or Gerlitz wrote:
>> On Thu, Jun 19, 2014 at 6:33 AM, Shirley Ma <[e-mail]> wrote:
>>> 1. Whether IB VFs is supported in ConnectX-2 (mlx4 driver)?
>>>
>>> I tried to num_vfs={port1,port2,port1+2} when loading mlx4_core module, it failed with mlx4_core 0000:40:00.0: Invalid syntax of num_vfs/probe_vfs with IB port - single port VFs syntax is only supported when all ports are configured as ethernet
>>
>> What do you mean by "port1" and "port2" -- can you give the exact
>> command line you used?
>>
>> Single ported VFs are currently supported for Ethernet only
>> configuration, that is not for only IB nor for VPI, that is only if
>> you use port_type_arrary=2,2
>>
> I tried command line with num_vfs without port_type_array=2,2.
>
> num_vfs=2
> num_vfs={1,1,2}
>
> both failed.

Please provide further details on what fails when you use num_vfs=2, 
here it works just fine, e.g send us the output of

$ modprobe -v mlx4_core

and the related dmesg

As for the crash you reported, indeed, it seems we have a bug there on 
the error flow of module loading when single ported VF are requested in 
conjunction with IB ports. I have it fixed on my system with this patch 
which are will review etc


 From 6dec77e0dc68679e4127de19f6798151cc8b2fe6 Mon Sep 17 00:00:00 2001
From: Or Gerlitz <[e-mail]>
Date: Sun, 22 Jun 2014 13:46:04 +0300
Subject: [PATCH] net/mlx4_core: Return error when module is loaded with 
invalid VF configuration

Single ported VF are currently not supported on configurations where
one or both ports are IB. When we hit this case, the module load
function didn't return error, fix that.

Fixes: dd41cc3 ('net/mlx4: Adapt num_vfs/probed_vf params for single 
port VF')
Signed-off-by: Or Gerlitz <[e-mail]>
---
  drivers/net/ethernet/mellanox/mlx4/main.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

                         }
                         for (i = 0; i < sizeof(nvfs)/sizeof(nvfs[0]); 
i++) {
--
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Or Gerlitz June 22, 2014, 10:25 a.m. UTC | #1

On Sun, Jun 22, 2014 at 12:29 PM, Or Gerlitz <[e-mail]> wrote:
>
> As for the crash you reported, indeed, it seems we have a bug there on the error flow of module loading when single ported VF are requested in conjunction with IB ports. I have it fixed on my system with this patch which are will review etc


Just posted a patch fixing the crash you reported to netdev
http://marc.info/?l=linux-netdev&m=140343252214146&w=2

Thanks for the report and tell us if you have further issues.

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c 
b/drivers/net/ethernet/mellanox/mlx4/main.c
index 5f42f6d..4f4d48c 100644
--- a/drivers/net/ethernet/mellanox/mlx4/main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -2439,6 +2439,7 @@  slave_start:
                             (num_vfs_argc > 1 || probe_vfs_argc > 1)) {
                                 mlx4_err(dev,
                                          "Invalid syntax of 
num_vfs/probe_vfs with IB port - single port VFs syntax is only 
supported when all ports are configured as ethernet\n");
+                               err = -EINVAL;
                                 goto err_close;