| Message ID | 8a4343e217d7d1c0a5a786b785c4ac57cb72a2a0.1744288299.git.leonro@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [rdma-rc] RDMA/bnxt_re: Remove unusable nq variable | expand |
On Thu, Apr 10, 2025 at 03:32:20PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@nvidia.com> > > Remove nq variable from bnxt_re_create_srq() and bnxt_re_destroy_srq() > as it generates the following compilation warnings: > > >> drivers/infiniband/hw/bnxt_re/ib_verbs.c:1777:24: warning: variable > 'nq' set but not used [-Wunused-but-set-variable] > 1777 | struct bnxt_qplib_nq *nq = NULL; > | ^ > drivers/infiniband/hw/bnxt_re/ib_verbs.c:1828:24: warning: variable > 'nq' set but not used [-Wunused-but-set-variable] > 1828 | struct bnxt_qplib_nq *nq = NULL; > | ^ > 2 warnings generated. > > Fixes: 6b395d31146a ("RDMA/bnxt_re: Fix budget handling of notification queue") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202504091055.CzgXnk4C-lkp@intel.com/ > Signed-off-by: Leon Romanovsky <leonro@nvidia.com> > --- > drivers/infiniband/hw/bnxt_re/ib_verbs.c | 5 ----- > 1 file changed, 5 deletions(-) Applied to for-next, thanks Jason
On Thu, Apr 10, 2025 at 6:02 PM Leon Romanovsky <leon@kernel.org> wrote: > > From: Leon Romanovsky <leonro@nvidia.com> > > Remove nq variable from bnxt_re_create_srq() and bnxt_re_destroy_srq() > as it generates the following compilation warnings: > > >> drivers/infiniband/hw/bnxt_re/ib_verbs.c:1777:24: warning: variable > 'nq' set but not used [-Wunused-but-set-variable] > 1777 | struct bnxt_qplib_nq *nq = NULL; > | ^ > drivers/infiniband/hw/bnxt_re/ib_verbs.c:1828:24: warning: variable > 'nq' set but not used [-Wunused-but-set-variable] > 1828 | struct bnxt_qplib_nq *nq = NULL; > | ^ > 2 warnings generated. > > Fixes: 6b395d31146a ("RDMA/bnxt_re: Fix budget handling of notification queue") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202504091055.CzgXnk4C-lkp@intel.com/ > Signed-off-by: Leon Romanovsky <leonro@nvidia.com> Thank you Leon for the patch, LGTM. > --- > drivers/infiniband/hw/bnxt_re/ib_verbs.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c > index e14b05cd089a..063801384b2b 100644 > --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c > +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c > @@ -1774,10 +1774,7 @@ int bnxt_re_destroy_srq(struct ib_srq *ib_srq, struct ib_udata *udata) > ib_srq); > struct bnxt_re_dev *rdev = srq->rdev; > struct bnxt_qplib_srq *qplib_srq = &srq->qplib_srq; > - struct bnxt_qplib_nq *nq = NULL; > > - if (qplib_srq->cq) > - nq = qplib_srq->cq->nq; > if (rdev->chip_ctx->modes.toggle_bits & BNXT_QPLIB_SRQ_TOGGLE_BIT) { > free_page((unsigned long)srq->uctx_srq_page); > hash_del(&srq->hash_entry); > @@ -1825,7 +1822,6 @@ int bnxt_re_create_srq(struct ib_srq *ib_srq, > struct ib_udata *udata) > { > struct bnxt_qplib_dev_attr *dev_attr; > - struct bnxt_qplib_nq *nq = NULL; > struct bnxt_re_ucontext *uctx; > struct bnxt_re_dev *rdev; > struct bnxt_re_srq *srq; > @@ -1871,7 +1867,6 @@ int bnxt_re_create_srq(struct ib_srq *ib_srq, > srq->qplib_srq.eventq_hw_ring_id = rdev->nqr->nq[0].ring_id; > srq->qplib_srq.sg_info.pgsize = PAGE_SIZE; > srq->qplib_srq.sg_info.pgshft = PAGE_SHIFT; > - nq = &rdev->nqr->nq[0]; > > if (udata) { > rc = bnxt_re_init_user_srq(rdev, pd, srq, udata); > -- > 2.49.0 >
diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c index e14b05cd089a..063801384b2b 100644 --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c @@ -1774,10 +1774,7 @@ int bnxt_re_destroy_srq(struct ib_srq *ib_srq, struct ib_udata *udata) ib_srq); struct bnxt_re_dev *rdev = srq->rdev; struct bnxt_qplib_srq *qplib_srq = &srq->qplib_srq; - struct bnxt_qplib_nq *nq = NULL; - if (qplib_srq->cq) - nq = qplib_srq->cq->nq; if (rdev->chip_ctx->modes.toggle_bits & BNXT_QPLIB_SRQ_TOGGLE_BIT) { free_page((unsigned long)srq->uctx_srq_page); hash_del(&srq->hash_entry); @@ -1825,7 +1822,6 @@ int bnxt_re_create_srq(struct ib_srq *ib_srq, struct ib_udata *udata) { struct bnxt_qplib_dev_attr *dev_attr; - struct bnxt_qplib_nq *nq = NULL; struct bnxt_re_ucontext *uctx; struct bnxt_re_dev *rdev; struct bnxt_re_srq *srq; @@ -1871,7 +1867,6 @@ int bnxt_re_create_srq(struct ib_srq *ib_srq, srq->qplib_srq.eventq_hw_ring_id = rdev->nqr->nq[0].ring_id; srq->qplib_srq.sg_info.pgsize = PAGE_SIZE; srq->qplib_srq.sg_info.pgshft = PAGE_SHIFT; - nq = &rdev->nqr->nq[0]; if (udata) { rc = bnxt_re_init_user_srq(rdev, pd, srq, udata);