diff mbox series

[rdma-next,1/4] RDMA/mlx5: Drop redundant work canceling from clean_keys()

Message ID 943d21f5a9dba7b98a3e1d531e3561ffe9745d71.1725362530.git.leon@kernel.org (mailing list archive)
State Accepted
Headers show
Series Batch of mlx5 MR cache fixes | expand

Commit Message

Leon Romanovsky Sept. 3, 2024, 11:24 a.m. UTC 
From: Michael Guralnik <michaelgur@nvidia.com>

The canceling of dealyed work in clean_keys() is a leftover from years
back and was added to prevent races in the cleanup process of MR cache.
The cleanup process was rewritten a few years ago and the canceling of
delayed work and flushing of workqueue was added before the call to
clean_keys().

Signed-off-by: Michael Guralnik <michaelgur@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
 drivers/infiniband/hw/mlx5/mr.c | 1 -
 1 file changed, 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
index 6829e3688b60..3945df08beec 100644
--- a/drivers/infiniband/hw/mlx5/mr.c
+++ b/drivers/infiniband/hw/mlx5/mr.c
@@ -772,7 +772,6 @@  static void clean_keys(struct mlx5_ib_dev *dev, struct mlx5_cache_ent *ent)
 {
 	u32 mkey;
 
-	cancel_delayed_work(&ent->dwork);
 	spin_lock_irq(&ent->mkeys_queue.lock);
 	while (ent->mkeys_queue.ci) {
 		mkey = pop_mkey_locked(ent);