[RFC] Add source address binding to iSER

First off, I've never done anything this complicated, please be gentle.

Second, I know this will need to be broken up, but I'm not clear if
each commit should be able to compile. It seems having a commit for
each driver would make sense, but it won't compile cleanly without the
others. How do I go about that?

Third, this required a change to the kernel API(?) and I'm not sure
the best way to to make that change backwards compatible.

Forth, I'm getting an error on login. I don't think the kernel is even
trying the login. Maybe I can get a pointer to help me get this
resolved.

# usr/iscsiadm -m iface -I iser3
# BEGIN RECORD 2.0-874
iface.iscsi_ifacename = iser3
iface.net_ifacename = <empty>
iface.ipaddress = fd00::14
...
# usr/iscsiadm -m iface -I iser4
# BEGIN RECORD 2.0-874
iface.iscsi_ifacename = iser4
iface.net_ifacename = <empty>
iface.ipaddress = fd00::114
...
# usr/iscsiadm -m discovery -t st -p fd00::13 -I iser3 -I iser4
[fd00::13]:3260,1 iqn.2016-12.com.betterservers
[fd00::13]:3260,1 iqn.2016-12.com.betterservers
# usr/iscsiadm -m node -T iqn.2016-12.com.betterservers -p [fd00::13]:3260 -l
Logging in to [iface: iser3, target: iqn.2016-12.com.betterservers,
portal: fd00::13,3260] (multiple)
Logging in to [iface: iser4, target: iqn.2016-12.com.betterservers,
portal: fd00::13,3260] (multiple)
iscsiadm: Could not login to [iface: iser3, target:
iqn.2016-12.com.betterservers, portal: fd00::13,3260].
iscsiadm: initiator reported error (12 - iSCSI driver not found.
Please make sure it is loaded, and retry the operation)
iscsiadm: Could not login to [iface: iser4, target:
iqn.2016-12.com.betterservers, portal: fd00::13,3260].
iscsiadm: initiator reported error (12 - iSCSI driver not found.
Please make sure it is loaded, and retry the operation)
iscsiadm: Could not log into all portals

Patch to open-iscsi
----------------------------
         int (*tgt_dscvr) (struct Scsi_Host *shost, enum iscsi_tgt_dscvr type,
@@ -291,6 +293,100 @@ struct iscsi_endpoint {
         struct iscsi_cls_conn *conn;
 };

+/* max len of interface */
+#define ISCSI_MAX_IFACE_LEN        65
+#define NI_MAXHOST 1025
+#define ISCSI_HWADDRESS_BUF_SIZE 18
+#define ISCSI_TRANSPORT_NAME_MAXLEN 16
+#define ISCSI_MAX_STR_LEN 80
+
+struct iface_rec {
+        struct list_head        list;
+        /* iscsi iface record name */
+        char                        name[ISCSI_MAX_IFACE_LEN];
+        uint32_t                iface_num;
+        /* network layer iface name (eth0) */
+        char                        netdev[IFNAMSIZ];
+        char                        ipaddress[NI_MAXHOST];
+        char                        subnet_mask[NI_MAXHOST];
+        char                        gateway[NI_MAXHOST];
+        char                        bootproto[ISCSI_MAX_STR_LEN];
+        char                        ipv6_linklocal[NI_MAXHOST];
+        char                        ipv6_router[NI_MAXHOST];
+        char                        ipv6_autocfg[NI_MAXHOST];
+        char                        linklocal_autocfg[NI_MAXHOST];
+        char                        router_autocfg[NI_MAXHOST];
+        uint16_t                vlan_id;
+        uint8_t                        vlan_priority;
+        char                        vlan_state[ISCSI_MAX_STR_LEN];
+        char                        state[ISCSI_MAX_STR_LEN]; /* 0 = disable,
+                                                           * 1 = enable */
+        uint16_t                mtu;
+        uint16_t                port;
+        char                        delayed_ack[ISCSI_MAX_STR_LEN];
+        char                        nagle[ISCSI_MAX_STR_LEN];
+        char                        tcp_wsf_state[ISCSI_MAX_STR_LEN];
+        uint8_t                        tcp_wsf;
+        uint8_t                        tcp_timer_scale;
+        char                        tcp_timestamp[ISCSI_MAX_STR_LEN];
+        char                        dhcp_dns[ISCSI_MAX_STR_LEN];
+        char                        dhcp_slp_da[ISCSI_MAX_STR_LEN];
+        char                        tos_state[ISCSI_MAX_STR_LEN];
+        uint8_t                        tos;
+        char                        gratuitous_arp[ISCSI_MAX_STR_LEN];
+        char
dhcp_alt_client_id_state[ISCSI_MAX_STR_LEN];
+        char                        dhcp_alt_client_id[ISCSI_MAX_STR_LEN];
+        char
dhcp_req_vendor_id_state[ISCSI_MAX_STR_LEN];
+        char                        dhcp_vendor_id_state[ISCSI_MAX_STR_LEN];
+        char                        dhcp_vendor_id[ISCSI_MAX_STR_LEN];
+        char                        dhcp_learn_iqn[ISCSI_MAX_STR_LEN];
+        char                        fragmentation[ISCSI_MAX_STR_LEN];
+        char                        incoming_forwarding[ISCSI_MAX_STR_LEN];
+        uint8_t                        ttl;
+        char                        gratuitous_neighbor_adv[ISCSI_MAX_STR_LEN];
+        char                        redirect[ISCSI_MAX_STR_LEN];
+        char                        mld[ISCSI_MAX_STR_LEN];
+        uint32_t                flow_label;
+        uint32_t                traffic_class;
+        uint8_t                        hop_limit;
+        uint32_t                nd_reachable_tmo;
+        uint32_t                nd_rexmit_time;
+        uint32_t                nd_stale_tmo;
+        uint8_t                        dup_addr_detect_cnt;
+        uint32_t                router_adv_link_mtu;
+        uint16_t                def_task_mgmt_tmo;
+        char                        header_digest[ISCSI_MAX_STR_LEN];
+        char                        data_digest[ISCSI_MAX_STR_LEN];
+        char                        immediate_data[ISCSI_MAX_STR_LEN];
+        char                        initial_r2t[ISCSI_MAX_STR_LEN];
+        char                        data_seq_inorder[ISCSI_MAX_STR_LEN];
+        char                        data_pdu_inorder[ISCSI_MAX_STR_LEN];
+        uint8_t                        erl;
+        uint32_t                max_recv_dlength;
+        uint32_t                first_burst_len;
+        uint16_t                max_out_r2t;
+        uint32_t                max_burst_len;
+        char                        chap_auth[ISCSI_MAX_STR_LEN];
+        char                        bidi_chap[ISCSI_MAX_STR_LEN];
+        char                        strict_login_comp[ISCSI_MAX_STR_LEN];
+        char                        discovery_auth[ISCSI_MAX_STR_LEN];
+        char                        discovery_logout[ISCSI_MAX_STR_LEN];
+        char                        port_state[ISCSI_MAX_STR_LEN];
+        char                        port_speed[ISCSI_MAX_STR_LEN];
+        /*
+         * TODO: we may have to make this bigger and interconnect
+         * specific for infiniband
+         */
+        char                        hwaddress[ISCSI_HWADDRESS_BUF_SIZE];
+        char
transport_name[ISCSI_TRANSPORT_NAME_MAXLEN];
+        /*
+         * This is only used for boot now, but the iser guys
+         * can use this for their virtualization idea.
+         */
+        char                        alias[TARGET_NAME_MAXLEN + 1];
+        char                        iname[TARGET_NAME_MAXLEN + 1];
+};
+
 struct iscsi_iface {
         struct device dev;
         struct iscsi_transport *transport;

Thank you,

----------------
Robert LeBlanc
PGP Fingerprint 79A2 9CA4 6CC4 45DD A904  C70E E654 3BB2 FA62 B9F1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[RFC] Add source address binding to iSER

Commit Message

Patch