| Message ID | OSZP286MB1629E3E8563657C551711194FEFB9@OSZP286MB1629.JPNP286.PROD.OUTLOOK.COM (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | net/mlx5: correct ECE offset in query qp output | expand |
On Tue, Apr 26, 2022 at 10:06:11PM +0800, Changcheng Liu wrote: > > From cd2890fc0f756d809f684768fabb34b449df6d29 Mon Sep 17 00:00:00 2001 > From: Changcheng Liu <jerrliu@nvidia.com> > Date: Tue, 26 Apr 2022 21:28:14 +0800 > Subject: [PATCH] net/mlx5: correct ECE offset in query qp output > > ECE field should be after opt_param_mask in query qp output. > > Fixes: 6b646a7e4af6 ("net/mlx5: Add ability to read and write ECE options") > Signed-off-by: Changcheng Liu <jerrliu@nvidia.com> Saeed, Do you plan to add new patches to mlx5-next? This change can go to that branch as this field is not used in current code at all. Thanks > > diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h > index 7d2d0ba82144..2e162ec2a3d3 100644 > --- a/include/linux/mlx5/mlx5_ifc.h > +++ b/include/linux/mlx5/mlx5_ifc.h > @@ -5180,12 +5180,11 @@ struct mlx5_ifc_query_qp_out_bits { > > u8 syndrome[0x20]; > > - u8 reserved_at_40[0x20]; > - u8 ece[0x20]; > + u8 reserved_at_40[0x40]; > > u8 opt_param_mask[0x20]; > > - u8 reserved_at_a0[0x20]; > + u8 ece[0x20]; > > struct mlx5_ifc_qpc_bits qpc; > > -- > 2.27.0 >
On 02 May 14:24, Leon Romanovsky wrote: >On Tue, Apr 26, 2022 at 10:06:11PM +0800, Changcheng Liu wrote: >> >> From cd2890fc0f756d809f684768fabb34b449df6d29 Mon Sep 17 00:00:00 2001 >> From: Changcheng Liu <jerrliu@nvidia.com> >> Date: Tue, 26 Apr 2022 21:28:14 +0800 >> Subject: [PATCH] net/mlx5: correct ECE offset in query qp output >> Patches withtout a target branch [net] or [net-next] are invisible to netdev patchwork, please for next time add a target branch to the title. >> ECE field should be after opt_param_mask in query qp output. >> >> Fixes: 6b646a7e4af6 ("net/mlx5: Add ability to read and write ECE options") >> Signed-off-by: Changcheng Liu <jerrliu@nvidia.com> > >Saeed, > >Do you plan to add new patches to mlx5-next? >This change can go to that branch as this field is not used in current >code at all. > I don't mind, i will apply to net-next-mlx5, and keep it there until the end of this release until i am sure it introduces no conflicts, I don't see any point of putting this in mlx5-next at this time.
diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h index 7d2d0ba82144..2e162ec2a3d3 100644 --- a/include/linux/mlx5/mlx5_ifc.h +++ b/include/linux/mlx5/mlx5_ifc.h @@ -5180,12 +5180,11 @@ struct mlx5_ifc_query_qp_out_bits { u8 syndrome[0x20]; - u8 reserved_at_40[0x20]; - u8 ece[0x20]; + u8 reserved_at_40[0x40]; u8 opt_param_mask[0x20]; - u8 reserved_at_a0[0x20]; + u8 ece[0x20]; struct mlx5_ifc_qpc_bits qpc;