| Message ID | Y7zCBqwC1LtabRJ9@work (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [next] RDMA/erdma: Replace zero-length arrays with flexible-array members | expand |
On 1/10/23 9:40 AM, Gustavo A. R. Silva wrote: > Zero-length arrays are deprecated[1] and we are moving towards > adopting C99 flexible-array members instead. So, replace zero-length > arrays, in a couple of structures, with flex-array members. > > This helps with the ongoing efforts to tighten the FORTIFY_SOURCE > routines on memcpy() and help us make progress towards globally > enabling -fstrict-flex-arrays=3 [2]. > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays [1] > Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [2] > Link: https://github.com/KSPP/linux/issues/78 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > drivers/infiniband/hw/erdma/erdma_hw.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Acked-by: Cheng Xu <chengyou@linux.alibaba.com> Thanks very much, Cheng Xu > diff --git a/drivers/infiniband/hw/erdma/erdma_hw.h b/drivers/infiniband/hw/erdma/erdma_hw.h > index ab371fec610c..4c38d99c73f1 100644 > --- a/drivers/infiniband/hw/erdma/erdma_hw.h > +++ b/drivers/infiniband/hw/erdma/erdma_hw.h > @@ -397,7 +397,7 @@ struct erdma_write_sqe { > > __le32 rsvd; > > - struct erdma_sge sgl[0]; > + struct erdma_sge sgl[]; > }; > > struct erdma_send_sqe { > @@ -408,7 +408,7 @@ struct erdma_send_sqe { > }; > > __le32 length; > - struct erdma_sge sgl[0]; > + struct erdma_sge sgl[]; > }; > > struct erdma_readreq_sqe {
On Mon, Jan 09, 2023 at 07:40:22PM -0600, Gustavo A. R. Silva wrote: > Zero-length arrays are deprecated[1] and we are moving towards > adopting C99 flexible-array members instead. So, replace zero-length > arrays, in a couple of structures, with flex-array members. > > This helps with the ongoing efforts to tighten the FORTIFY_SOURCE > routines on memcpy() and help us make progress towards globally > enabling -fstrict-flex-arrays=3 [2]. > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays [1] > Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [2] > Link: https://github.com/KSPP/linux/issues/78 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Reviewed-by: Kees Cook <keescook@chromium.org>
On Mon, 09 Jan 2023 19:40:22 -0600, Gustavo A. R. Silva wrote: > Zero-length arrays are deprecated[1] and we are moving towards > adopting C99 flexible-array members instead. So, replace zero-length > arrays, in a couple of structures, with flex-array members. > > This helps with the ongoing efforts to tighten the FORTIFY_SOURCE > routines on memcpy() and help us make progress towards globally > enabling -fstrict-flex-arrays=3 [2]. > > [...] Applied, thanks! [1/1] RDMA/erdma: Replace zero-length arrays with flexible-array members https://git.kernel.org/rdma/rdma/c/ed73a505480d54 Best regards,
diff --git a/drivers/infiniband/hw/erdma/erdma_hw.h b/drivers/infiniband/hw/erdma/erdma_hw.h index ab371fec610c..4c38d99c73f1 100644 --- a/drivers/infiniband/hw/erdma/erdma_hw.h +++ b/drivers/infiniband/hw/erdma/erdma_hw.h @@ -397,7 +397,7 @@ struct erdma_write_sqe { __le32 rsvd; - struct erdma_sge sgl[0]; + struct erdma_sge sgl[]; }; struct erdma_send_sqe { @@ -408,7 +408,7 @@ struct erdma_send_sqe { }; __le32 length; - struct erdma_sge sgl[0]; + struct erdma_sge sgl[]; }; struct erdma_readreq_sqe {
Zero-length arrays are deprecated[1] and we are moving towards adopting C99 flexible-array members instead. So, replace zero-length arrays, in a couple of structures, with flex-array members. This helps with the ongoing efforts to tighten the FORTIFY_SOURCE routines on memcpy() and help us make progress towards globally enabling -fstrict-flex-arrays=3 [2]. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays [1] Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [2] Link: https://github.com/KSPP/linux/issues/78 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/infiniband/hw/erdma/erdma_hw.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)