| Message ID | alpine.DEB.2.20.1711101026470.29707@nuc-kabylake (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Fri, Nov 10, 2017 at 10:28:38AM -0600, Christopher Lameter wrote: > Subject: rdma-core: Fixup comments in librdmacm > > Fix up the two comments that Hal showed were incorrect. > > Signed-off-by: Christoph Lameter <cl@linux.com> Christopher, The first patch wasn't merged, so there is nothing to "fixup". Thanks
On Mon, 13 Nov 2017, Leon Romanovsky wrote:
> The first patch wasn't merged, so there is nothing to "fixup".
If the patchset is merged then the fixup is needed. This is quite a common
thing to post a fixup patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: rdma-core/librdmacm/cma.c =================================================================== --- rdma-core.orig/librdmacm/cma.c +++ rdma-core/librdmacm/cma.c @@ -2040,7 +2040,7 @@ static int ucma_process_join(struct cma_ if (!evt->id_priv->id.qp) return 0; - /* Don't attach QP to multicast if joined as send only */ + /* Don't attach QP to multicast if joined as send only full member */ if (evt->mc->join_flags == RDMA_MC_JOIN_FLAG_SENDONLY_FULLMEMBER) return 0; Index: rdma-core/librdmacm/rdma_cma.h =================================================================== --- rdma-core.orig/librdmacm/rdma_cma.h +++ rdma-core/librdmacm/rdma_cma.h @@ -578,7 +578,7 @@ int rdma_join_multicast(struct rdma_cm_i int rdma_leave_multicast(struct rdma_cm_id *id, struct sockaddr *addr); /** - * in_multicast_ex - Joins a multicast group with options. + * rdma_join_multicast_ex - Joins a multicast group with options. * @id: Communication identifier associated with the request. * @mc_join_attr: Extensive struct containing multicast join parameters. * @context: User-defined context associated with the join request.
Subject: rdma-core: Fixup comments in librdmacm Fix up the two comments that Hal showed were incorrect. Signed-off-by: Christoph Lameter <cl@linux.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html