| Message ID | dada9ed857f53514519bbf57828380fdc72c827f.1449500617.git.geliangtang@163.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Dec 07, 2015 at 11:04:43PM +0800, Geliang Tang wrote: > Simplify the code with list_for_each_entry_safe(). > > Signed-off-by: Geliang Tang <geliangtang@163.com> > --- > drivers/infiniband/hw/mlx4/mcg.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/infiniband/hw/mlx4/mcg.c b/drivers/infiniband/hw/mlx4/mcg.c > index 99451d8..ebdca2b 100644 > --- a/drivers/infiniband/hw/mlx4/mcg.c > +++ b/drivers/infiniband/hw/mlx4/mcg.c > @@ -747,14 +747,11 @@ static struct mcast_group *search_relocate_mgid0_group(struct mlx4_ib_demux_ctx > __be64 tid, > union ib_gid *new_mgid) > { > - struct mcast_group *group = NULL, *cur_group; > + struct mcast_group *group = NULL, *cur_group, *n; > struct mcast_req *req; > - struct list_head *pos; > - struct list_head *n; > > mutex_lock(&ctx->mcg_table_lock); > - list_for_each_safe(pos, n, &ctx->mcg_mgid0_list) { > - group = list_entry(pos, struct mcast_group, mgid0_list); > + list_for_each_entry_safe(group, n, &ctx->mcg_mgid0_list, mgid0_list) { > mutex_lock(&group->lock); > if (group->last_req_tid == tid) { > if (memcmp(new_mgid, &mgid0, sizeof mgid0)) { Thanks, Reviewed-by: Leon Romanovsky <leonro@mellanox.com> > -- > 2.5.0 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/mlx4/mcg.c b/drivers/infiniband/hw/mlx4/mcg.c index 99451d8..ebdca2b 100644 --- a/drivers/infiniband/hw/mlx4/mcg.c +++ b/drivers/infiniband/hw/mlx4/mcg.c @@ -747,14 +747,11 @@ static struct mcast_group *search_relocate_mgid0_group(struct mlx4_ib_demux_ctx __be64 tid, union ib_gid *new_mgid) { - struct mcast_group *group = NULL, *cur_group; + struct mcast_group *group = NULL, *cur_group, *n; struct mcast_req *req; - struct list_head *pos; - struct list_head *n; mutex_lock(&ctx->mcg_table_lock); - list_for_each_safe(pos, n, &ctx->mcg_mgid0_list) { - group = list_entry(pos, struct mcast_group, mgid0_list); + list_for_each_entry_safe(group, n, &ctx->mcg_mgid0_list, mgid0_list) { mutex_lock(&group->lock); if (group->last_req_tid == tid) { if (memcmp(new_mgid, &mgid0, sizeof mgid0)) {
Simplify the code with list_for_each_entry_safe(). Signed-off-by: Geliang Tang <geliangtang@163.com> --- drivers/infiniband/hw/mlx4/mcg.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)