[0/3] Fix tcsr_mutex register for IPQ6018

Message

Vignesh Viswanathan Sept. 4, 2023, 5:50 a.m. UTC

IPQ6018 has 32 tcsr_mutext hwlock registers of 0x1000 size each.
The compatible string qcom,ipq6018-tcsr-mutex is mapped to
of_msm8226_tcsr_mutex which has 32 locks configured with stride of 0x80
and doesn't match the HW present in IPQ6018.

This series fixes the following:
1. Fix the tcsr_mutex hwlock register size to 0x20000 in ipq6018.dtsi.
2. Remove qcom,ipq6018-tcsr-mutex compatible string for tcsr_mutex in
ipq6018.dtsi.
3. Drop unused qcom,ipq6018-tcsr-mutex compatible string from
qcom_hwspinlock driver and dt-bindings.

Vignesh Viswanathan (3):
  arm64: dts: qcom: ipq6018: Fix tcsr_mutex register size
  hwspinlock: qcom: Drop unused qcom,ipq6018-tcsr-mutex
  dt-bindings: hwlock: Drop unused qcom,ipq6018-tcsr-mutex

 Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml | 1 -
 arch/arm64/boot/dts/qcom/ipq6018.dtsi                         | 4 ++--
 drivers/hwspinlock/qcom_hwspinlock.c                          | 1 -
 3 files changed, 2 insertions(+), 4 deletions(-)

Comments

Konrad Dybcio Sept. 4, 2023, 3:58 p.m. UTC | #1

On 4.09.2023 07:50, Vignesh Viswanathan wrote:
> IPQ6018 has 32 tcsr_mutext hwlock registers of 0x1000 size each.
> The compatible string qcom,ipq6018-tcsr-mutex is mapped to
> of_msm8226_tcsr_mutex which has 32 locks configured with stride of 0x80
> and doesn't match the HW present in IPQ6018.
> 
> This series fixes the following:
> 1. Fix the tcsr_mutex hwlock register size to 0x20000 in ipq6018.dtsi.
> 2. Remove qcom,ipq6018-tcsr-mutex compatible string for tcsr_mutex in
> ipq6018.dtsi.
> 3. Drop unused qcom,ipq6018-tcsr-mutex compatible string from
> qcom_hwspinlock driver and dt-bindings.
> 
Sounds like [e-mail] can't
go in without this then?

Konrad

Vignesh Viswanathan Sept. 4, 2023, 5:27 p.m. UTC | #2

On 9/4/2023 9:28 PM, Konrad Dybcio wrote:
> On 4.09.2023 07:50, Vignesh Viswanathan wrote:
>> IPQ6018 has 32 tcsr_mutext hwlock registers of 0x1000 size each.
>> The compatible string qcom,ipq6018-tcsr-mutex is mapped to
>> of_msm8226_tcsr_mutex which has 32 locks configured with stride of 0x80
>> and doesn't match the HW present in IPQ6018.
>>
>> This series fixes the following:
>> 1. Fix the tcsr_mutex hwlock register size to 0x20000 in ipq6018.dtsi.
>> 2. Remove qcom,ipq6018-tcsr-mutex compatible string for tcsr_mutex in
>> ipq6018.dtsi.
>> 3. Drop unused qcom,ipq6018-tcsr-mutex compatible string from
>> qcom_hwspinlock driver and dt-bindings.
>>
> Sounds like [e-mail] can't
> go in without this then?
> 

They can independently go in as the current max size and stride set for
IPQ6018 still has 32 locks and moving the index 3 shouldn't cause any 
issues.

However, functionally IPQ6018's HW lock is broken and will be fixed once 
this series goes in.

Thanks,
Vignesh
> Konrad