| Message ID | 20230904055010.4118982-2-quic_viswanat@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix tcsr_mutex register for IPQ6018 | expand |
On 04/09/2023 07:50, Vignesh Viswanathan wrote: > IPQ6018 has 32 tcsr_mutex hwlock registers and size of each is 0x1000. > > Fix size of the tcsr_mutex hwlock register to 0x20000. > Also, remove the qcom,ipq6018-tcsr-mutex compatible as this maps to > incorrect stride and mutex config for IPQ6018 in hwspinlock driver. This is 6018, so if 6018 compatible is incorrect... this does not make any sense. NAK Best regards, Krzysztof
On 9/4/2023 12:10 PM, Krzysztof Kozlowski wrote: > On 04/09/2023 07:50, Vignesh Viswanathan wrote: >> IPQ6018 has 32 tcsr_mutex hwlock registers and size of each is 0x1000. >> >> Fix size of the tcsr_mutex hwlock register to 0x20000. >> Also, remove the qcom,ipq6018-tcsr-mutex compatible as this maps to >> incorrect stride and mutex config for IPQ6018 in hwspinlock driver. > > This is 6018, so if 6018 compatible is incorrect... this does not make > any sense. > > NAK > Understood, Instead of removing the 6018 compatible, I'll use the same and fix the config mapped to 6018 in the hwspinlock driver. Thanks, Vignesh > > Best regards, > Krzysztof >
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi index 47b8b1d6730a..56537cf8243f 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -392,8 +392,8 @@ gcc: gcc@1800000 { }; tcsr_mutex: hwlock@1905000 { - compatible = "qcom,ipq6018-tcsr-mutex", "qcom,tcsr-mutex"; - reg = <0x0 0x01905000 0x0 0x1000>; + compatible = "qcom,tcsr-mutex"; + reg = <0x0 0x01905000 0x0 0x20000>; #hwlock-cells = <1>; };
IPQ6018 has 32 tcsr_mutex hwlock registers and size of each is 0x1000. Fix size of the tcsr_mutex hwlock register to 0x20000. Also, remove the qcom,ipq6018-tcsr-mutex compatible as this maps to incorrect stride and mutex config for IPQ6018 in hwspinlock driver. Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com> --- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)