| Message ID | 20220920030316.1619781-4-sireeshkodali1@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | remoteproc: qcom: Add support for pronto-v3 | expand |
On 20/09/2022 05:03, Sireesh Kodali wrote: > This is not a fallback compatible, it must be present in addition to > "qcom,pronto-v*". It is also not documented in qcom,wcnss-pil.txt. This > is the reason for documenting it in a separate commit. > > This compatible is used in the wcn36xx driver to determine which > register must be accessed. However it isn't immediately clear why the > wcn36xx driver relies on this extra compatible string rather than just > looking for "qcom,pronto-v*". > > Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com> It's a v3. What are the changes? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml index bb499ae9a4f0..31232c59b22b 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.yaml @@ -15,10 +15,15 @@ description: properties: compatible: - enum: - - qcom,riva-pil - - qcom,pronto-v1-pil - - qcom,pronto-v2-pil + description: + Append "qcom,pronto" if the device is actually pronto, and not riva + oneOf: + - items: + - enum: + - qcom,pronto-v1-pil + - qcom,pronto-v2-pil + - const: qcom,pronto + - const: qcom,riva-pil reg: maxItems: 3
This is not a fallback compatible, it must be present in addition to "qcom,pronto-v*". It is also not documented in qcom,wcnss-pil.txt. This is the reason for documenting it in a separate commit. This compatible is used in the wcn36xx driver to determine which register must be accessed. However it isn't immediately clear why the wcn36xx driver relies on this extra compatible string rather than just looking for "qcom,pronto-v*". Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com> --- .../bindings/remoteproc/qcom,wcnss-pil.yaml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)