| Message ID | 20180925163337.31212-3-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0dc733988b813b4054e2243539855ef535d3c9dd |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | R-Car D3/E3 display DT enablement | expand |
On 9/25/2018 7:33 PM, Laurent Pinchart wrote: > From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > The r8a77995 D3 platform has 2 LVDS channels connected to the DU. > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > [uli: moved lvds* into the soc node, added PM domains, resets] > Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Tested-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 56 +++++++++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > index 89a04a4496fd..214f4954b321 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > @@ -972,12 +972,68 @@ > port@1 { > reg = <1>; > du_out_lvds0: endpoint { > + remote-endpoint = <&lvds0_in>; > }; > }; > > port@2 { > reg = <2>; > du_out_lvds1: endpoint { > + remote-endpoint = <&lvds1_in>; > + }; > + }; > + }; > + }; > + > + lvds0: lvds-encoder@feb90000 { > + compatible = "renesas,r8a77995-lvds"; > + reg = <0 0xfeb90000 0 0x20>; > + clocks = <&cpg CPG_MOD 727>; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 727>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + lvds0_in: endpoint { > + remote-endpoint = <&du_out_lvds0>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + lvds0_out: endpoint { > + }; > + }; > + }; > + }; > + > + lvds1: lvds-encoder@feb90100 { > + compatible = "renesas,r8a77995-lvds"; > + reg = <0 0xfeb90100 0 0x20>; > + clocks = <&cpg CPG_MOD 727>; Not 726? > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 726>; ... like here? [...] MBR, Sergei
On Wed, Sep 26, 2018 at 11:27:53AM +0300, Sergei Shtylyov wrote: > On 9/25/2018 7:33 PM, Laurent Pinchart wrote: > > > From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > > > The r8a77995 D3 platform has 2 LVDS channels connected to the DU. > > > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > [uli: moved lvds* into the soc node, added PM domains, resets] > > Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Tested-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > --- > > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 56 +++++++++++++++++++++++++++++++ > > 1 file changed, 56 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > > index 89a04a4496fd..214f4954b321 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > > @@ -972,12 +972,68 @@ > > port@1 { > > reg = <1>; > > du_out_lvds0: endpoint { > > + remote-endpoint = <&lvds0_in>; > > }; > > }; > > port@2 { > > reg = <2>; > > du_out_lvds1: endpoint { > > + remote-endpoint = <&lvds1_in>; > > + }; > > + }; > > + }; > > + }; > > + > > + lvds0: lvds-encoder@feb90000 { > > + compatible = "renesas,r8a77995-lvds"; > > + reg = <0 0xfeb90000 0 0x20>; > > + clocks = <&cpg CPG_MOD 727>; > > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > > + resets = <&cpg 727>; > > + status = "disabled"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + lvds0_in: endpoint { > > + remote-endpoint = <&du_out_lvds0>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + lvds0_out: endpoint { > > + }; > > + }; > > + }; > > + }; > > + > > + lvds1: lvds-encoder@feb90100 { > > + compatible = "renesas,r8a77995-lvds"; > > + reg = <0 0xfeb90100 0 0x20>; > > + clocks = <&cpg CPG_MOD 727>; > > Not 726? > > > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > > + resets = <&cpg 726>; > > ... like here? I believe that discussion was already had for v2 of the similar patch for r8a77990 and that it is intentional.
On 9/26/2018 12:13 PM, Simon Horman wrote: >>> From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> >>> >>> The r8a77995 D3 platform has 2 LVDS channels connected to the DU. >>> >>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> >>> [uli: moved lvds* into the soc node, added PM domains, resets] >>> Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu> >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>> Tested-by: Jacopo Mondi <jacopo+renesas@jmondi.org> >>> --- >>> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 56 +++++++++++++++++++++++++++++++ >>> 1 file changed, 56 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi >>> index 89a04a4496fd..214f4954b321 100644 >>> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi >>> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi >>> @@ -972,12 +972,68 @@ >>> port@1 { >>> reg = <1>; >>> du_out_lvds0: endpoint { >>> + remote-endpoint = <&lvds0_in>; >>> }; >>> }; >>> port@2 { >>> reg = <2>; >>> du_out_lvds1: endpoint { >>> + remote-endpoint = <&lvds1_in>; >>> + }; >>> + }; >>> + }; >>> + }; >>> + >>> + lvds0: lvds-encoder@feb90000 { >>> + compatible = "renesas,r8a77995-lvds"; >>> + reg = <0 0xfeb90000 0 0x20>; >>> + clocks = <&cpg CPG_MOD 727>; >>> + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; >>> + resets = <&cpg 727>; >>> + status = "disabled"; >>> + >>> + ports { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + port@0 { >>> + reg = <0>; >>> + lvds0_in: endpoint { >>> + remote-endpoint = <&du_out_lvds0>; >>> + }; >>> + }; >>> + >>> + port@1 { >>> + reg = <1>; >>> + lvds0_out: endpoint { >>> + }; >>> + }; >>> + }; >>> + }; >>> + >>> + lvds1: lvds-encoder@feb90100 { >>> + compatible = "renesas,r8a77995-lvds"; >>> + reg = <0 0xfeb90100 0 0x20>; >>> + clocks = <&cpg CPG_MOD 727>; >> >> Not 726? >> >>> + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; >>> + resets = <&cpg 726>; >> >> ... like here? > > I believe that discussion was already had for v2 of the similar patch > for r8a77990 and that it is intentional. Ah, sorry, missed that. Still looks like a documentation error... :-) MBR, Sergei
On Wed, Sep 26, 2018 at 12:46:12PM +0300, Sergei Shtylyov wrote: > On 9/26/2018 12:13 PM, Simon Horman wrote: > > > > > From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > > > > > > > The r8a77995 D3 platform has 2 LVDS channels connected to the DU. > > > > > > > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > > > [uli: moved lvds* into the soc node, added PM domains, resets] > > > > Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu> > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > Tested-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > > > --- > > > > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 56 +++++++++++++++++++++++++++++++ > > > > 1 file changed, 56 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > > > > index 89a04a4496fd..214f4954b321 100644 > > > > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > > > > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > > > > @@ -972,12 +972,68 @@ > > > > port@1 { > > > > reg = <1>; > > > > du_out_lvds0: endpoint { > > > > + remote-endpoint = <&lvds0_in>; > > > > }; > > > > }; > > > > port@2 { > > > > reg = <2>; > > > > du_out_lvds1: endpoint { > > > > + remote-endpoint = <&lvds1_in>; > > > > + }; > > > > + }; > > > > + }; > > > > + }; > > > > + > > > > + lvds0: lvds-encoder@feb90000 { > > > > + compatible = "renesas,r8a77995-lvds"; > > > > + reg = <0 0xfeb90000 0 0x20>; > > > > + clocks = <&cpg CPG_MOD 727>; > > > > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > > > > + resets = <&cpg 727>; > > > > + status = "disabled"; > > > > + > > > > + ports { > > > > + #address-cells = <1>; > > > > + #size-cells = <0>; > > > > + > > > > + port@0 { > > > > + reg = <0>; > > > > + lvds0_in: endpoint { > > > > + remote-endpoint = <&du_out_lvds0>; > > > > + }; > > > > + }; > > > > + > > > > + port@1 { > > > > + reg = <1>; > > > > + lvds0_out: endpoint { > > > > + }; > > > > + }; > > > > + }; > > > > + }; > > > > + > > > > + lvds1: lvds-encoder@feb90100 { > > > > + compatible = "renesas,r8a77995-lvds"; > > > > + reg = <0 0xfeb90100 0 0x20>; > > > > + clocks = <&cpg CPG_MOD 727>; > > > > > > Not 726? > > > > > > > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > > > > + resets = <&cpg 726>; > > > > > > ... like here? > > > > I believe that discussion was already had for v2 of the similar patch > > for r8a77990 and that it is intentional. > > Ah, sorry, missed that. Still looks like a documentation error... :-) Yes, that is my understanding too.
diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index 89a04a4496fd..214f4954b321 100644 --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi @@ -972,12 +972,68 @@ port@1 { reg = <1>; du_out_lvds0: endpoint { + remote-endpoint = <&lvds0_in>; }; }; port@2 { reg = <2>; du_out_lvds1: endpoint { + remote-endpoint = <&lvds1_in>; + }; + }; + }; + }; + + lvds0: lvds-encoder@feb90000 { + compatible = "renesas,r8a77995-lvds"; + reg = <0 0xfeb90000 0 0x20>; + clocks = <&cpg CPG_MOD 727>; + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; + resets = <&cpg 727>; + status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + lvds0_in: endpoint { + remote-endpoint = <&du_out_lvds0>; + }; + }; + + port@1 { + reg = <1>; + lvds0_out: endpoint { + }; + }; + }; + }; + + lvds1: lvds-encoder@feb90100 { + compatible = "renesas,r8a77995-lvds"; + reg = <0 0xfeb90100 0 0x20>; + clocks = <&cpg CPG_MOD 727>; + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; + resets = <&cpg 726>; + status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + lvds1_in: endpoint { + remote-endpoint = <&du_out_lvds1>; + }; + }; + + port@1 { + reg = <1>; + lvds1_out: endpoint { }; }; };