| Message ID | 20200717132859.237120-5-jacopo+renesas@jmondi.org (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | dt-bindings: media: ov5640: Convert to json-schema | expand |
Hi Jacopo, Thank you for the patch. On Fri, Jul 17, 2020 at 03:28:50PM +0200, Jacopo Mondi wrote: > The newly introduced dt-schema bindings for the ov5640 image > sensor triggered a warning in the ti,cal.yaml bindings file, which > has a camera sensor node marked compatible with the sensor. > > As in the example is enough to report a node for the device that > the bindings is about, and maintaining the sensor node up-to-date > is a non-necessary burden, remove the image sensor node from the > ti,cal bindings file. The sensor node in the example gives a bit more clarity, but it's also not super important. I'll let Tomi decide if he wants to keep it (and thus get it fixed), or if he's fine dropping it. Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > .../devicetree/bindings/media/ti,cal.yaml | 22 ------------------- > 1 file changed, 22 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/ti,cal.yaml b/Documentation/devicetree/bindings/media/ti,cal.yaml > index 5e066629287d..fe5c74dd246e 100644 > --- a/Documentation/devicetree/bindings/media/ti,cal.yaml > +++ b/Documentation/devicetree/bindings/media/ti,cal.yaml > @@ -177,26 +177,4 @@ examples: > }; > }; > > - i2c { > - clock-frequency = <400000>; > - #address-cells = <1>; > - #size-cells = <0>; > - > - camera-sensor@3c { > - compatible = "ovti,ov5640"; > - reg = <0x3c>; > - > - clocks = <&clk_ov5640_fixed>; > - clock-names = "xclk"; > - > - port { > - csi2_cam0: endpoint { > - remote-endpoint = <&csi2_phy0>; > - clock-lanes = <0>; > - data-lanes = <1 2>; > - }; > - }; > - }; > - }; > - > ...
On Fri, 17 Jul 2020 15:28:50 +0200, Jacopo Mondi wrote: > The newly introduced dt-schema bindings for the ov5640 image > sensor triggered a warning in the ti,cal.yaml bindings file, which > has a camera sensor node marked compatible with the sensor. > > As in the example is enough to report a node for the device that > the bindings is about, and maintaining the sensor node up-to-date > is a non-necessary burden, remove the image sensor node from the > ti,cal bindings file. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > .../devicetree/bindings/media/ti,cal.yaml | 22 ------------------- > 1 file changed, 22 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/media/ti,cal.yaml b/Documentation/devicetree/bindings/media/ti,cal.yaml index 5e066629287d..fe5c74dd246e 100644 --- a/Documentation/devicetree/bindings/media/ti,cal.yaml +++ b/Documentation/devicetree/bindings/media/ti,cal.yaml @@ -177,26 +177,4 @@ examples: }; }; - i2c { - clock-frequency = <400000>; - #address-cells = <1>; - #size-cells = <0>; - - camera-sensor@3c { - compatible = "ovti,ov5640"; - reg = <0x3c>; - - clocks = <&clk_ov5640_fixed>; - clock-names = "xclk"; - - port { - csi2_cam0: endpoint { - remote-endpoint = <&csi2_phy0>; - clock-lanes = <0>; - data-lanes = <1 2>; - }; - }; - }; - }; - ...
The newly introduced dt-schema bindings for the ov5640 image sensor triggered a warning in the ti,cal.yaml bindings file, which has a camera sensor node marked compatible with the sensor. As in the example is enough to report a node for the device that the bindings is about, and maintaining the sensor node up-to-date is a non-necessary burden, remove the image sensor node from the ti,cal bindings file. Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- .../devicetree/bindings/media/ti,cal.yaml | 22 ------------------- 1 file changed, 22 deletions(-) -- 2.27.0