| Message ID | 20210630073013.22415-10-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [v3,01/11] dt-bindings: usb: generic-ohci: Document dr_mode property | expand |
On Wed, Jun 30, 2021 at 08:30:11AM +0100, Biju Das wrote: > Document RZ/G2L (R9A07G044L) SoC bindings. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > v3: > * Updated the bindings as per the USBPHY control IP. > --- > .../bindings/usb/renesas,usbhs.yaml | 21 +++++++++++++++++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > index ad73339ffe1d..5562839bef8d 100644 > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > @@ -17,7 +17,9 @@ properties: > - const: renesas,rza1-usbhs > > - items: > - - const: renesas,usbhs-r7s9210 # RZ/A2 > + - enum: > + - renesas,usbhs-r7s9210 # RZ/A2 > + - renesas,usbhs-r9a07g044 # RZ/G2{L,LC} > - const: renesas,rza2-usbhs > > - items: > @@ -59,7 +61,7 @@ properties: > - description: USB 2.0 clock selector > > interrupts: > - maxItems: 1 > + minItems: 1 maxItems: 4 > > renesas,buswait: > $ref: /schemas/types.yaml#/definitions/uint32 > @@ -108,6 +110,21 @@ required: > - clocks > - interrupts > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: renesas,usbhs-r9a07g044 > + then: > + properties: > + interrupts: > + items: > + - description: U2P_IXL_INT > + - description: U2P_INT_DMA[0] > + - description: U2P_INT_DMA[1] > + - description: U2P_INT_DMAERR If the first interrupt is the same on all devices, then this items list should be moved to the top level and just have a 'minItems: 4' here. else: properties: interrupts: maxItems: 1 > + > additionalProperties: false > > examples: > -- > 2.17.1 > >
Hi Rob, Thanks for the feedback. > Subject: Re: [PATCH v3 09/11] dt-bindings: usb: renesas,usbhs: Document > RZ/G2L bindings > > On Wed, Jun 30, 2021 at 08:30:11AM +0100, Biju Das wrote: > > Document RZ/G2L (R9A07G044L) SoC bindings. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > --- > > v3: > > * Updated the bindings as per the USBPHY control IP. > > --- > > .../bindings/usb/renesas,usbhs.yaml | 21 +++++++++++++++++-- > > 1 file changed, 19 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > index ad73339ffe1d..5562839bef8d 100644 > > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > @@ -17,7 +17,9 @@ properties: > > - const: renesas,rza1-usbhs > > > > - items: > > - - const: renesas,usbhs-r7s9210 # RZ/A2 > > + - enum: > > + - renesas,usbhs-r7s9210 # RZ/A2 > > + - renesas,usbhs-r9a07g044 # RZ/G2{L,LC} > > - const: renesas,rza2-usbhs > > > > - items: > > @@ -59,7 +61,7 @@ properties: > > - description: USB 2.0 clock selector > > > > interrupts: > > - maxItems: 1 > > + minItems: 1 > > maxItems: 4 OK. > > > > > renesas,buswait: > > $ref: /schemas/types.yaml#/definitions/uint32 > > @@ -108,6 +110,21 @@ required: > > - clocks > > - interrupts > > > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: renesas,usbhs-r9a07g044 > > + then: > > + properties: > > + interrupts: > > + items: > > + - description: U2P_IXL_INT > > + - description: U2P_INT_DMA[0] > > + - description: U2P_INT_DMA[1] > > + - description: U2P_INT_DMAERR > > If the first interrupt is the same on all devices, then this items list > should be moved to the top level and just have a 'minItems: 4' > here. From the hardware point, it is same "HSUSB interrupt" But HW manual is representing it differently R-Car Gen2, RZ/G1:-USB2.0_597 (OTG) R-Car Gen3, RZ/G2:- EHCI/OHCI OTG.ch0 RZ/G2L: U2P_IXL_INT Other devices ??. So it make sense to leave as it is. Please let me know if you think other wise. Regards, Biju > > > else: > properties: > interrupts: > maxItems: 1 > > > > + > > additionalProperties: false > > > > examples: > > -- > > 2.17.1 > > > >
diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml index ad73339ffe1d..5562839bef8d 100644 --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml @@ -17,7 +17,9 @@ properties: - const: renesas,rza1-usbhs - items: - - const: renesas,usbhs-r7s9210 # RZ/A2 + - enum: + - renesas,usbhs-r7s9210 # RZ/A2 + - renesas,usbhs-r9a07g044 # RZ/G2{L,LC} - const: renesas,rza2-usbhs - items: @@ -59,7 +61,7 @@ properties: - description: USB 2.0 clock selector interrupts: - maxItems: 1 + minItems: 1 renesas,buswait: $ref: /schemas/types.yaml#/definitions/uint32 @@ -108,6 +110,21 @@ required: - clocks - interrupts +allOf: + - if: + properties: + compatible: + contains: + const: renesas,usbhs-r9a07g044 + then: + properties: + interrupts: + items: + - description: U2P_IXL_INT + - description: U2P_INT_DMA[0] + - description: U2P_INT_DMA[1] + - description: U2P_INT_DMAERR + additionalProperties: false examples: