| Message ID | 20230411120810.368437-3-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | Add RZ/{G2L,G2LC} and RZ/V2L DU support | expand |
On Tue, 11 Apr 2023 13:08:04 +0100, Biju Das wrote: > Document DU found in RZ/V2L SoC. The DU block is identical to RZ/G2L > SoC and therefore use RZ/G2L fallback to avoid any driver changes. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > v7: > * New patch. > --- > .../devicetree/bindings/display/renesas,rzg2l-du.yaml | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
Hi Biju, On Tue, Apr 11, 2023 at 2:11 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > Document DU found in RZ/V2L SoC. The DU block is identical to RZ/G2L > SoC and therefore use RZ/G2L fallback to avoid any driver changes. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > v7: > * New patch. Thanks for your patch! > --- a/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml > +++ b/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml > @@ -16,8 +16,13 @@ description: | > > properties: > compatible: > - enum: > - - renesas,r9a07g044-du # RZ/G2{L,LC} > + oneOf: > + - enum: > + - renesas,r9a07g044-du # RZ/G2{L,LC} > + - items: > + - enum: > + - renesas,r9a07g054-vsp2 # RZ/V2L > + - const: renesas,r9a07g044-vsp2 # RZ/G2L fallback "*-vsp2", really? ;-) And with s/vsp2/du/, it doesn't match patch 6/8, where you use "renesas,r9a07g054-du" without the fallback. Gr{oetje,eeting}s, Geert
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v7 2/8] dt-bindings: display: renesas,rzg2l-du: Document > RZ/V2L DU bindings > > Hi Biju, > > On Tue, Apr 11, 2023 at 2:11 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > Document DU found in RZ/V2L SoC. The DU block is identical to RZ/G2L > > SoC and therefore use RZ/G2L fallback to avoid any driver changes. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > v7: > > * New patch. > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml > > +++ b/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml > > @@ -16,8 +16,13 @@ description: | > > > > properties: > > compatible: > > - enum: > > - - renesas,r9a07g044-du # RZ/G2{L,LC} > > + oneOf: > > + - enum: > > + - renesas,r9a07g044-du # RZ/G2{L,LC} > > + - items: > > + - enum: > > + - renesas,r9a07g054-vsp2 # RZ/V2L > > + - const: renesas,r9a07g044-vsp2 # RZ/G2L fallback > > "*-vsp2", really? ;-) > > And with s/vsp2/du/, it doesn't match patch 6/8, where you use > "renesas,r9a07g054-du" without the fallback. Oops, Typo. Copy paste error from vsp2. OK, will use compatible r9a07g044-du as fallback in 6/8 and in driver. as both G2L and V2L supports either DSI or DPI. Cheers, Biju
diff --git a/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml b/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml index 7626043debd8..e29ba0145f89 100644 --- a/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml +++ b/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml @@ -16,8 +16,13 @@ description: | properties: compatible: - enum: - - renesas,r9a07g044-du # RZ/G2{L,LC} + oneOf: + - enum: + - renesas,r9a07g044-du # RZ/G2{L,LC} + - items: + - enum: + - renesas,r9a07g054-vsp2 # RZ/V2L + - const: renesas,r9a07g044-vsp2 # RZ/G2L fallback reg: maxItems: 1
Document DU found in RZ/V2L SoC. The DU block is identical to RZ/G2L SoC and therefore use RZ/G2L fallback to avoid any driver changes. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- v7: * New patch. --- .../devicetree/bindings/display/renesas,rzg2l-du.yaml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)