diff mbox series

[v7,4/8] drm: rzg2l-du: Add RZ/V2L DU Support

Message ID 20230411120810.368437-5-biju.das.jz@bp.renesas.com (mailing list archive)
State Superseded
Delegated to: Kieran Bingham
Headers show
Series Add RZ/{G2L,G2LC} and RZ/V2L DU support | expand

Commit Message

Biju Das April 11, 2023, 12:08 p.m. UTC
Add support for RZ/V2L DU. The RZ/V2L DU block is identical to
RZ/G2L SoC.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v7:
 * New patch.
---
 drivers/gpu/drm/rcar-du/rzg2l_du_drv.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Geert Uytterhoeven April 20, 2023, 2:47 p.m. UTC | #1
Hi Biju,

On Tue, Apr 11, 2023 at 2:08 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Add support for RZ/V2L DU. The RZ/V2L DU block is identical to
> RZ/G2L SoC.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v7:
>  * New patch.

Thanks for your patch!

> --- a/drivers/gpu/drm/rcar-du/rzg2l_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rzg2l_du_drv.c
> @@ -53,6 +53,7 @@ static const struct rcar_du_device_info rzg2l_du_r9a07g044_info = {
>
>  static const struct of_device_id rzg2l_du_of_table[] = {
>         { .compatible = "renesas,r9a07g044-du", .data = &rzg2l_du_r9a07g044_info },
> +       { .compatible = "renesas,r9a07g054-du", .data = &rzg2l_du_r9a07g044_info },
>         { /* sentinel */ }

So this change implies no fallback compatible value, OK.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
Biju Das April 20, 2023, 3:13 p.m. UTC | #2
Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: Thursday, April 20, 2023 3:48 PM
> To: Biju Das <biju.das.jz@bp.renesas.com>
> Cc: David Airlie <airlied@gmail.com>; Daniel Vetter <daniel@ffwll.ch>; Mauro
> Carvalho Chehab <mchehab@kernel.org>; Rob Herring <robh+dt@kernel.org>;
> Krzysztof Kozlowski <krzk+dt@kernel.org>; Laurent Pinchart
> <laurent.pinchart+renesas@ideasonboard.com>; dri-
> devel@lists.freedesktop.org; devicetree@vger.kernel.org; linux-
> media@vger.kernel.org; Geert Uytterhoeven <geert+renesas@glider.be>; Chris
> Paterson <Chris.Paterson2@renesas.com>; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@bp.renesas.com>; linux-renesas-soc@vger.kernel.org
> Subject: Re: [PATCH v7 4/8] drm: rzg2l-du: Add RZ/V2L DU Support
> 
> Hi Biju,
> 
> On Tue, Apr 11, 2023 at 2:08 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > Add support for RZ/V2L DU. The RZ/V2L DU block is identical to RZ/G2L
> > SoC.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > v7:
> >  * New patch.
> 
> Thanks for your patch!
> 
> > --- a/drivers/gpu/drm/rcar-du/rzg2l_du_drv.c
> > +++ b/drivers/gpu/drm/rcar-du/rzg2l_du_drv.c
> > @@ -53,6 +53,7 @@ static const struct rcar_du_device_info
> > rzg2l_du_r9a07g044_info = {
> >
> >  static const struct of_device_id rzg2l_du_of_table[] = {
> >         { .compatible = "renesas,r9a07g044-du", .data =
> > &rzg2l_du_r9a07g044_info },
> > +       { .compatible = "renesas,r9a07g054-du", .data =
> > + &rzg2l_du_r9a07g044_info },
> >         { /* sentinel */ }
> 
> So this change implies no fallback compatible value, OK.

I am planning to drop this patch in next version to make use of
fallback compatible as discussed in patch 6/8.

Cheers,
Biju


> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
>                                 -- Linus Torvalds
diff mbox series

Patch

diff --git a/drivers/gpu/drm/rcar-du/rzg2l_du_drv.c b/drivers/gpu/drm/rcar-du/rzg2l_du_drv.c
index be9aeccbfdc7..6d7f20e3af39 100644
--- a/drivers/gpu/drm/rcar-du/rzg2l_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rzg2l_du_drv.c
@@ -53,6 +53,7 @@  static const struct rcar_du_device_info rzg2l_du_r9a07g044_info = {
 
 static const struct of_device_id rzg2l_du_of_table[] = {
 	{ .compatible = "renesas,r9a07g044-du", .data = &rzg2l_du_r9a07g044_info },
+	{ .compatible = "renesas,r9a07g054-du", .data = &rzg2l_du_r9a07g044_info },
 	{ /* sentinel */ }
 };