| Message ID | 2408d7841c91e98e9a2b24b1b4df9b2b865519a6.1685696114.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | drm: Atomic modesetting doc and comment improvements | expand |
Hi Geert, Thanks for the feedback. > Subject: [PATCH 3/3] drm: Fix references to > drm_plane_helper_check_state() > > As of commit a01cb8ba3f628293 ("drm: Move drm_plane_helper_check_state() > into drm_atomic_helper.c"), drm_plane_helper_check_state() no longer > exists, but is part of drm_atomic_helper_check_plane_state(). > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Interestingly, all these comments appeared only after the commit that > removed the function... > > This is against next-20230602, which does not have the drivers/gpu/drm/{ > => renesas}/rcar-du move yet. > > Biju: you're adding a new copy in > drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c OK, will update the comment in __rzg2l_du_vsp_plane_atomic_check() as it is moved to drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.c based on Laurent's review comment. Cheers, Biju > --- > drivers/gpu/drm/rcar-du/rcar_du_plane.c | 3 ++- > drivers/gpu/drm/tidss/tidss_plane.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c > b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > index d759e019218181ce..e445fac8e0b46c21 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > @@ -600,7 +600,8 @@ int __rcar_du_plane_atomic_check(struct drm_plane > *plane, > if (!state->crtc) { > /* > * The visible field is not reset by the DRM core but only > - * updated by drm_plane_helper_check_state(), set it > manually. > + * updated by drm_atomic_helper_check_plane_state(), set it > + * manually. > */ > state->visible = false; > *format = NULL; > diff --git a/drivers/gpu/drm/tidss/tidss_plane.c > b/drivers/gpu/drm/tidss/tidss_plane.c > index 6bdd6e4a955ab3cc..e1c0ef0c3894c855 100644 > --- a/drivers/gpu/drm/tidss/tidss_plane.c > +++ b/drivers/gpu/drm/tidss/tidss_plane.c > @@ -38,7 +38,8 @@ static int tidss_plane_atomic_check(struct drm_plane > *plane, > if (!new_plane_state->crtc) { > /* > * The visible field is not reset by the DRM core but only > - * updated by drm_plane_helper_check_state(), set it > manually. > + * updated by drm_atomic_helper_check_plane_state(), set it > + * manually. > */ > new_plane_state->visible = false; > return 0; > -- > 2.34.1
Hi Geert, Thank you for the patch. On Fri, Jun 02, 2023 at 11:11:36AM +0200, Geert Uytterhoeven wrote: > As of commit a01cb8ba3f628293 ("drm: Move drm_plane_helper_check_state() > into drm_atomic_helper.c"), drm_plane_helper_check_state() no longer > exists, but is part of drm_atomic_helper_check_plane_state(). > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > Interestingly, all these comments appeared only after the commit that > removed the function... > > This is against next-20230602, which does not have the > drivers/gpu/drm/{ => renesas}/rcar-du move yet. > > Biju: you're adding a new copy in > drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c > --- > drivers/gpu/drm/rcar-du/rcar_du_plane.c | 3 ++- > drivers/gpu/drm/tidss/tidss_plane.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > index d759e019218181ce..e445fac8e0b46c21 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > @@ -600,7 +600,8 @@ int __rcar_du_plane_atomic_check(struct drm_plane *plane, > if (!state->crtc) { > /* > * The visible field is not reset by the DRM core but only > - * updated by drm_plane_helper_check_state(), set it manually. > + * updated by drm_atomic_helper_check_plane_state(), set it > + * manually. > */ > state->visible = false; > *format = NULL; > diff --git a/drivers/gpu/drm/tidss/tidss_plane.c b/drivers/gpu/drm/tidss/tidss_plane.c > index 6bdd6e4a955ab3cc..e1c0ef0c3894c855 100644 > --- a/drivers/gpu/drm/tidss/tidss_plane.c > +++ b/drivers/gpu/drm/tidss/tidss_plane.c > @@ -38,7 +38,8 @@ static int tidss_plane_atomic_check(struct drm_plane *plane, > if (!new_plane_state->crtc) { > /* > * The visible field is not reset by the DRM core but only > - * updated by drm_plane_helper_check_state(), set it manually. > + * updated by drm_atomic_helper_check_plane_state(), set it > + * manually. > */ > new_plane_state->visible = false; > return 0;
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c b/drivers/gpu/drm/rcar-du/rcar_du_plane.c index d759e019218181ce..e445fac8e0b46c21 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c @@ -600,7 +600,8 @@ int __rcar_du_plane_atomic_check(struct drm_plane *plane, if (!state->crtc) { /* * The visible field is not reset by the DRM core but only - * updated by drm_plane_helper_check_state(), set it manually. + * updated by drm_atomic_helper_check_plane_state(), set it + * manually. */ state->visible = false; *format = NULL; diff --git a/drivers/gpu/drm/tidss/tidss_plane.c b/drivers/gpu/drm/tidss/tidss_plane.c index 6bdd6e4a955ab3cc..e1c0ef0c3894c855 100644 --- a/drivers/gpu/drm/tidss/tidss_plane.c +++ b/drivers/gpu/drm/tidss/tidss_plane.c @@ -38,7 +38,8 @@ static int tidss_plane_atomic_check(struct drm_plane *plane, if (!new_plane_state->crtc) { /* * The visible field is not reset by the DRM core but only - * updated by drm_plane_helper_check_state(), set it manually. + * updated by drm_atomic_helper_check_plane_state(), set it + * manually. */ new_plane_state->visible = false; return 0;
As of commit a01cb8ba3f628293 ("drm: Move drm_plane_helper_check_state() into drm_atomic_helper.c"), drm_plane_helper_check_state() no longer exists, but is part of drm_atomic_helper_check_plane_state(). Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Interestingly, all these comments appeared only after the commit that removed the function... This is against next-20230602, which does not have the drivers/gpu/drm/{ => renesas}/rcar-du move yet. Biju: you're adding a new copy in drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c --- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 3 ++- drivers/gpu/drm/tidss/tidss_plane.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)