| Message ID | 3f92b2c9dafbfeb8534d4e81b6899ef3249731f0.1687423204.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | drm: renesas: shmobile: Atomic conversion + DT support | expand |
Hi, On 2023/6/22 17:21, Geert Uytterhoeven wrote: > From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > Prepare for DT bindings by using more appropriate names for the input > clocks. > > Note that all LDDCKR_ICKSEL_* definitions but the one for the bus clock > are valid only for SH7724, so the clock selection code needs to be > updated when extending clock support to other SoCs. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > [geert: Add note] > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn> > --- > drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c > index d272e6273c782178..007ba97cc7733c82 100644 > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c > @@ -74,15 +74,15 @@ static int shmob_drm_setup_clocks(struct shmob_drm_device *sdev, > > switch (clksrc) { > case SHMOB_DRM_CLK_BUS: > - clkname = "bus_clk"; > + clkname = "fck"; > sdev->lddckr = LDDCKR_ICKSEL_BUS; > break; > case SHMOB_DRM_CLK_PERIPHERAL: > - clkname = "peripheral_clk"; > + clkname = "media"; > sdev->lddckr = LDDCKR_ICKSEL_MIPI; > break; > case SHMOB_DRM_CLK_EXTERNAL: > - clkname = NULL; > + clkname = "lclk"; > sdev->lddckr = LDDCKR_ICKSEL_HDMI; > break; > default:
diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c index d272e6273c782178..007ba97cc7733c82 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c @@ -74,15 +74,15 @@ static int shmob_drm_setup_clocks(struct shmob_drm_device *sdev, switch (clksrc) { case SHMOB_DRM_CLK_BUS: - clkname = "bus_clk"; + clkname = "fck"; sdev->lddckr = LDDCKR_ICKSEL_BUS; break; case SHMOB_DRM_CLK_PERIPHERAL: - clkname = "peripheral_clk"; + clkname = "media"; sdev->lddckr = LDDCKR_ICKSEL_MIPI; break; case SHMOB_DRM_CLK_EXTERNAL: - clkname = NULL; + clkname = "lclk"; sdev->lddckr = LDDCKR_ICKSEL_HDMI; break; default: