| Message ID | 736a0b26a9393f82769b185e2daa30eb128ff240.1687423204.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | drm: renesas: shmobile: Atomic conversion + DT support | expand |
Hi Geert, Thank you for the patch. On Thu, Jun 22, 2023 at 11:21:45AM +0200, Geert Uytterhoeven wrote: > Most unused callbacks can be NULL pointers these days. > Drop a bunch of empty encoder callbacks. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > .../gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 26 ------------------- > 1 file changed, 26 deletions(-) > > diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c > index b184019d8b1ed89c..ef327da39bca415a 100644 > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c > @@ -586,11 +586,6 @@ int shmob_drm_crtc_create(struct shmob_drm_device *sdev) > * Encoder > */ > > -static void shmob_drm_encoder_dpms(struct drm_encoder *encoder, int mode) > -{ > - /* No-op, everything is handled in the CRTC code. */ > -} > - > static bool shmob_drm_encoder_mode_fixup(struct drm_encoder *encoder, > const struct drm_display_mode *mode, > struct drm_display_mode *adjusted_mode) > @@ -613,29 +608,8 @@ static bool shmob_drm_encoder_mode_fixup(struct drm_encoder *encoder, > return true; > } > > -static void shmob_drm_encoder_mode_prepare(struct drm_encoder *encoder) > -{ > - /* No-op, everything is handled in the CRTC code. */ > -} > - > -static void shmob_drm_encoder_mode_set(struct drm_encoder *encoder, > - struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode) > -{ > - /* No-op, everything is handled in the CRTC code. */ > -} > - > -static void shmob_drm_encoder_mode_commit(struct drm_encoder *encoder) > -{ > - /* No-op, everything is handled in the CRTC code. */ > -} > - > static const struct drm_encoder_helper_funcs encoder_helper_funcs = { > - .dpms = shmob_drm_encoder_dpms, > .mode_fixup = shmob_drm_encoder_mode_fixup, > - .prepare = shmob_drm_encoder_mode_prepare, > - .commit = shmob_drm_encoder_mode_commit, > - .mode_set = shmob_drm_encoder_mode_set, > }; > > int shmob_drm_encoder_create(struct shmob_drm_device *sdev)
diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c index b184019d8b1ed89c..ef327da39bca415a 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c @@ -586,11 +586,6 @@ int shmob_drm_crtc_create(struct shmob_drm_device *sdev) * Encoder */ -static void shmob_drm_encoder_dpms(struct drm_encoder *encoder, int mode) -{ - /* No-op, everything is handled in the CRTC code. */ -} - static bool shmob_drm_encoder_mode_fixup(struct drm_encoder *encoder, const struct drm_display_mode *mode, struct drm_display_mode *adjusted_mode) @@ -613,29 +608,8 @@ static bool shmob_drm_encoder_mode_fixup(struct drm_encoder *encoder, return true; } -static void shmob_drm_encoder_mode_prepare(struct drm_encoder *encoder) -{ - /* No-op, everything is handled in the CRTC code. */ -} - -static void shmob_drm_encoder_mode_set(struct drm_encoder *encoder, - struct drm_display_mode *mode, - struct drm_display_mode *adjusted_mode) -{ - /* No-op, everything is handled in the CRTC code. */ -} - -static void shmob_drm_encoder_mode_commit(struct drm_encoder *encoder) -{ - /* No-op, everything is handled in the CRTC code. */ -} - static const struct drm_encoder_helper_funcs encoder_helper_funcs = { - .dpms = shmob_drm_encoder_dpms, .mode_fixup = shmob_drm_encoder_mode_fixup, - .prepare = shmob_drm_encoder_mode_prepare, - .commit = shmob_drm_encoder_mode_commit, - .mode_set = shmob_drm_encoder_mode_set, }; int shmob_drm_encoder_create(struct shmob_drm_device *sdev)
Most unused callbacks can be NULL pointers these days. Drop a bunch of empty encoder callbacks. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- .../gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 26 ------------------- 1 file changed, 26 deletions(-)